From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2AF5B1FF141 for ; Mon, 16 Mar 2026 16:21:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44CC31F10A; Mon, 16 Mar 2026 16:21:55 +0100 (CET) From: Shan Shaji To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2 1/1] fix #7329: api: avoid overwriting existing IPv6 config method Date: Mon, 16 Mar 2026 16:21:01 +0100 Message-ID: <20260316152101.207406-3-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260316152101.207406-1-s.shaji@proxmox.com> References: <20260316152101.207406-1-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773674440430 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.123 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PWJZHHZUTYA77MBAGMOHRZTWXZIKB7CG X-Message-ID-Hash: PWJZHHZUTYA77MBAGMOHRZTWXZIKB7CG X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If the inet6 address family's cidr6/gatway6 values are not present, the interface.method6 values is mutated with `NetworkConfigMethod::Manual` even if the interface.method6 already has a value. For example, if the config method is `auto` then it gets replaced by `Manual` config method. Later, when writing the config file to the interfaces.new file if the config method is manual and if there are no IPv6 specific attributes present, then the inet6 stanza gets skipped. In order to fix the issue update the condition to only set the config method to `::Manual` if there is no value present inside the `method6` property of the interface object. Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7329 Signed-off-by: Shan Shaji --- **note**: This is a new patch. src/api2/node/network.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/api2/node/network.rs b/src/api2/node/network.rs index 4ee0231d..d0a04e59 100644 --- a/src/api2/node/network.rs +++ b/src/api2/node/network.rs @@ -782,7 +782,7 @@ pub fn update_interface( if interface.cidr6.is_some() || interface.gateway6.is_some() { interface.method6 = Some(NetworkConfigMethod::Static); - } else { + } else if interface.method6.is_none() { interface.method6 = Some(NetworkConfigMethod::Manual); } -- 2.47.3