From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7E08B1FF140 for ; Fri, 13 Mar 2026 14:12:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CFDF62564; Fri, 13 Mar 2026 14:12:14 +0100 (CET) From: Daniel Herzig To: pve-devel@lists.proxmox.com Subject: [RFC PATCH qemu-server 2/4] drive: ignore 'dismissable' parameter for everything but CD-ROMs Date: Fri, 13 Mar 2026 14:12:04 +0100 Message-ID: <20260313131206.277195-3-d.herzig@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260313131206.277195-1-d.herzig@proxmox.com> References: <20260313131206.277195-1-d.herzig@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -1.534 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: EXV3PGYGKID3BBUZYRTQFG7LKAWJFWE4 X-Message-ID-Hash: EXV3PGYGKID3BBUZYRTQFG7LKAWJFWE4 X-MailFrom: dherzig@emma.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Daniel Herzig --- src/PVE/QemuServer/Drive.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm index 8539a1d3..43f89aae 100644 --- a/src/PVE/QemuServer/Drive.pm +++ b/src/PVE/QemuServer/Drive.pm @@ -854,6 +854,8 @@ sub parse_drive { if ($res->{media} && ($res->{media} eq 'cdrom')) { return if $res->{snapshot} || $res->{format}; return if $res->{interface} eq 'virtio'; + } else { + return if $res->{dismissable}; } if (my $size = $res->{size}) { -- 2.47.3