From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EF4341FF144 for ; Tue, 10 Mar 2026 17:10:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3B8BB49BF; Tue, 10 Mar 2026 17:10:00 +0100 (CET) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v1 proxmox-backup 3/3] api: backup: disallow incremental backups with different index length Date: Tue, 10 Mar 2026 17:04:00 +0100 Message-ID: <20260310160537.182153-4-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310160537.182153-1-r.obkircher@proxmox.com> References: <20260310160537.182153-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773158933400 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SK2W6NRKGKBJ4JGMQTCA5R4FZTN6EQDQ X-Message-ID-Hash: SK2W6NRKGKBJ4JGMQTCA5R4FZTN6EQDQ X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Restore the previous restrictions because fixed index files are only reused for qemu backups where the total size never changes. Signed-off-by: Robert Obkircher --- src/api2/backup/mod.rs | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/api2/backup/mod.rs b/src/api2/backup/mod.rs index 3c044c78..4a37947b 100644 --- a/src/api2/backup/mod.rs +++ b/src/api2/backup/mod.rs @@ -498,6 +498,11 @@ fn create_fixed_index( let mut incremental = false; if let Some(csum) = reuse_csum { incremental = true; + + if size.is_none() { + bail!("size is required for incremental backups"); + } + let last_backup = match &env.last_backup { Some(info) => info, None => { @@ -531,6 +536,14 @@ fn create_fixed_index( let mut writer = env.datastore.create_fixed_writer(&path, size, chunk_size)?; if let Some(reader) = reader { + // compares chunk count instead of size for backwards compatability + if writer.index_length() != reader.index_count() { + bail!( + "cannot reuse index - index sizes not equal ({} != {})", + writer.index_length(), + reader.index_count() + ); + } writer.clone_data_from(&reader)?; } -- 2.47.3