From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 685761FF138 for ; Wed, 04 Mar 2026 14:42:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D4B159D80; Wed, 4 Mar 2026 14:43:15 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: applied: [PATCH qemu-server] guest fsfreeze: fix applying default value for configuration sub-property Date: Wed, 4 Mar 2026 14:42:27 +0100 Message-ID: <20260304134232.144519-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772631734144 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.073 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.668 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.322 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1.141 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WMOWKQBGGFNHE46NN6VZANJHYCY2MCAD X-Message-ID-Hash: WMOWKQBGGFNHE46NN6VZANJHYCY2MCAD X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The && operator has higher precedence than //, so parentheses are needed. Fixes: 7546da2c ("api: import: follow guest-fsfreeze setting") Fixes: 9d359700 ("fix #1964: honor guest-fsfreeze setting for replications and snapshots") Fixes: 08ae75f5 ("api: clone_vm: follow guest-fsfreeze setting") Signed-off-by: Fiona Ebner --- src/PVE/API2/Qemu.pm | 4 ++-- src/PVE/QemuConfig.pm | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 1f0864f5..59ff8181 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -375,7 +375,7 @@ my $import_from_volid = sub { my ($src_storeid) = PVE::Storage::parse_volume_id($src_volid); my $qga = $src_conf->{agent} - && PVE::QemuServer::Agent::get_qga_key($src_conf, 'guest-fsfreeze') // 1; + && (PVE::QemuServer::Agent::get_qga_key($src_conf, 'guest-fsfreeze') // 1); return PVE::QemuServer::clone_disk( $storecfg, @@ -4560,7 +4560,7 @@ __PACKAGE__->register_method({ if $opt eq 'efidisk0'; my $qga = $oldconf->{agent} - && PVE::QemuServer::Agent::get_qga_key($oldconf, 'guest-fsfreeze') // 1; + && (PVE::QemuServer::Agent::get_qga_key($oldconf, 'guest-fsfreeze') // 1); my $newdrive = PVE::QemuServer::clone_disk( $storecfg, diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm index 6b90b8bb..462d1d6d 100644 --- a/src/PVE/QemuConfig.pm +++ b/src/PVE/QemuConfig.pm @@ -299,7 +299,7 @@ sub __snapshot_check_freeze_needed { $running && PVE::QemuServer::Agent::get_qga_key($config, 'enabled') && PVE::QemuServer::Agent::qga_check_running($vmid) - && PVE::QemuServer::Agent::get_qga_key($config, 'guest-fsfreeze') // 1, + && (PVE::QemuServer::Agent::get_qga_key($config, 'guest-fsfreeze') // 1), ); } else { return ($running, 0); -- 2.47.3