From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 880021FF137 for ; Tue, 03 Mar 2026 17:49:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C831B1DB9B; Tue, 3 Mar 2026 17:50:15 +0100 (CET) From: Samuel Rufinatscha To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v6 1/4] pbs-config: add token.shadow generation to ConfigVersionCache Date: Tue, 3 Mar 2026 17:49:50 +0100 Message-ID: <20260303165005.373120-2-s.rufinatscha@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260303165005.373120-1-s.rufinatscha@proxmox.com> References: <20260303165005.373120-1-s.rufinatscha@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772556586784 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.250 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DI65M77GIL6VFULX5TALNXRGVJWSFN7Y X-Message-ID-Hash: DI65M77GIL6VFULX5TALNXRGVJWSFN7Y X-MailFrom: s.rufinatscha@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Prepares the config version cache to support token_shadow caching. Safety: the shmem mapping is fixed to 4096 bytes via the #[repr(C)] union padding, and the new atomic is appended to the end of the #[repr(C)] inner struct, so all existing field offsets stay unchanged. Old processes keep accessing the same bytes and new processes consume previously reserved padding. Signed-off-by: Samuel Rufinatscha --- Changes from v5 to v6: * Rebased Changes from v4 to v5: * Rebased Changes from v3 to v4: * Rebased * Adjusted commit message Changes from v2 to v3: * Rebased Changes from v1 to v2: * Rebased pbs-config/src/config_version_cache.rs | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/pbs-config/src/config_version_cache.rs b/pbs-config/src/config_version_cache.rs index b875f7e0..399a6f79 100644 --- a/pbs-config/src/config_version_cache.rs +++ b/pbs-config/src/config_version_cache.rs @@ -27,6 +27,8 @@ struct ConfigVersionCacheDataInner { traffic_control_generation: AtomicUsize, // datastore (datastore.cfg) generation/version datastore_generation: AtomicUsize, + // Token shadow (token.shadow) generation/version. + token_shadow_generation: AtomicUsize, // Add further atomics here } @@ -159,4 +161,20 @@ impl ConfigVersionCache { .datastore_generation .fetch_add(1, Ordering::AcqRel) } + + /// Returns the token shadow generation number. + pub fn token_shadow_generation(&self) -> usize { + self.shmem + .data() + .token_shadow_generation + .load(Ordering::Acquire) + } + + /// Increase the token shadow generation number. + pub fn increase_token_shadow_generation(&self) -> usize { + self.shmem + .data() + .token_shadow_generation + .fetch_add(1, Ordering::AcqRel) + } } -- 2.47.3