From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 903501FF137 for ; Tue, 03 Mar 2026 16:22:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2B8501A4F0; Tue, 3 Mar 2026 16:23:29 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox v4 03/13] shared-memory: expose msync to flush in-memory contents to filesystem Date: Tue, 3 Mar 2026 16:22:45 +0100 Message-ID: <20260303152317.934256-4-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260303152317.934256-1-c.ebner@proxmox.com> References: <20260303152317.934256-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772551381304 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3TZFR4Z7SURPGHVMAICCGWRZUELSXKOX X-Message-ID-Hash: 3TZFR4Z7SURPGHVMAICCGWRZUELSXKOX X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Exposes proxmox_sys::mmap::Mmap::msync() to allow flushing all in-memory contents to the underlying mmapped file. Without this, it is not guaranteed that contents are persisted until unmapping, which can lead to data loss in case of host crashes or OOM situations. Signed-off-by: Christian Ebner --- proxmox-shared-memory/src/lib.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/proxmox-shared-memory/src/lib.rs b/proxmox-shared-memory/src/lib.rs index da057366..cd67c63a 100644 --- a/proxmox-shared-memory/src/lib.rs +++ b/proxmox-shared-memory/src/lib.rs @@ -12,7 +12,7 @@ use std::path::Path; use anyhow::{bail, format_err, Error}; use nix::errno::Errno; use nix::fcntl::OFlag; -use nix::sys::mman::{MapFlags, ProtFlags}; +use nix::sys::mman::{MapFlags, MsFlags, ProtFlags}; use nix::sys::stat::Mode; use proxmox_sys::error::SysError; @@ -230,6 +230,11 @@ impl SharedMemory { pub fn data_mut(&mut self) -> &mut T { &mut self.mmap[0] } + + /// Flush all in-memory contents to the backing file. + pub fn msync(&self, flags: MsFlags) -> Result<(), Error> { + self.mmap.msync(flags).map_err(Into::into) + } } /// Helper to initialize nested data -- 2.47.3