From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A70291FF142 for ; Mon, 02 Mar 2026 15:45:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BEEBB36BC8; Mon, 2 Mar 2026 15:46:49 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH common/qemu-server v5 0/5] improve multiarch build support Date: Mon, 2 Mar 2026 15:46:33 +0100 Message-ID: <20260302144642.3783463-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -1.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.012 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1.188 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.93 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GF3DOTVSJBMIA2X4JD7AVAAGDFOA7VZO X-Message-ID-Hash: GF3DOTVSJBMIA2X4JD7AVAAGDFOA7VZO X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Improves multiarch build by improving our mocking capabilities and test. changes from v4: * move file helper to PVE::File (pve-common; new patch) * rename 'get_file_size' to 'file_get_size' (same convention as 'file_get_contents') * fix a comment that was not true anymore * improve the 'file_get_size' mocked function (thanks @Fiona) * add a reset for 'all_cpu_models' in the initialize function - should not matter in practice, but could become a bug in the tests. changes from v3: * new file helpers for ovmf that get mocked * changed some comment wording * require '$arch' in 'get_cpu_models_by_arch' changes from v2: * split the first patch up in two * use the get_host_arch helper everywhere in the package * use a getter that auto-intiializes the global cpu model list pve-common: Dominik Csapak (1): file: add exists and size helper src/PVE/File.pm | 14 ++++++++++++++ 1 file changed, 14 insertions(+) qemu-server: Dominik Csapak (4): ovmf: use helpers that can be mocked for tests tests: improve multiarch build support by introducing local get_host_arch helper tests: improve multiarch build support by allowing re-init of cpu models tests: cfg2cmd: add some architecture tests src/PVE/API2/Qemu/Machine.pm | 3 +- src/PVE/QemuServer.pm | 5 +- src/PVE/QemuServer/CPUConfig.pm | 288 ++++++++++-------- src/PVE/QemuServer/Helpers.pm | 8 +- src/PVE/QemuServer/OVMF.pm | 24 +- src/test/Makefile | 5 +- src/test/cfg2cmd/aarch64/simple-arm-host.conf | 17 ++ .../cfg2cmd/aarch64/simple-arm-host.conf.cmd | 41 +++ src/test/cfg2cmd/aarch64/simple-arm.conf | 17 ++ src/test/cfg2cmd/aarch64/simple-arm.conf.cmd | 41 +++ src/test/run_config2command_tests.pl | 31 +- 11 files changed, 328 insertions(+), 152 deletions(-) create mode 100644 src/test/cfg2cmd/aarch64/simple-arm-host.conf create mode 100644 src/test/cfg2cmd/aarch64/simple-arm-host.conf.cmd create mode 100644 src/test/cfg2cmd/aarch64/simple-arm.conf create mode 100644 src/test/cfg2cmd/aarch64/simple-arm.conf.cmd Summary over all repositories: 12 files changed, 342 insertions(+), 152 deletions(-) -- Generated by git-murpp 0.8.1