From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 89F3B1FF142 for ; Mon, 02 Mar 2026 14:49:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8829834485; Mon, 2 Mar 2026 14:50:05 +0100 (CET) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH manager v1 1/1] api: startall: print info message if guest is skipped due to no onboot Date: Mon, 2 Mar 2026 14:49:29 +0100 Message-ID: <20260302134929.136399-1-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772459348369 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 62MO4GI2ZWDOBJ5QHI3ITNI46RG5N5JX X-Message-ID-Hash: 62MO4GI2ZWDOBJ5QHI3ITNI46RG5N5JX X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The documentation states that startall only starts guests with onboot=1 by default, and that this behavior can be overridden using the force parameter. However, when startall is invoked via the pvenode CLI without the force parameter, the Bulk Start task silently completes with just "TASK OK", giving no indication of why certain VMs were not started. The added informational message addresses this by clearly communicating to users why those VMs were skipped. Signed-off-by: Michael Köppl --- I encountered this while using startall and stopall myself and while RTFM would indeed have helped, I still felt that an informational message would improve the user's experience, especially since stopall will stop all VMs without force=1, whereas startall requires the force param. I only added the informational messages and did not change any behavior because the behavior makes sense to me after thinking about it some more. PVE/API2/Nodes.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 5bd6fe492..3faa1e800 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1969,7 +1969,12 @@ sub get_start_stop_list { my $resList = {}; foreach my $vmid (keys %$vmlist) { my $conf = $vmlist->{$vmid}->{conf}; - next if $autostart && !$conf->{onboot}; + + if ($autostart && !$conf->{onboot}) { + print + "skipping $vmid because 'onboot' is not set in guest config, use 'force' parameter to override\n"; + next; + } my $startup = $conf->{startup} ? PVE::JSONSchema::pve_parse_startup_order($conf->{startup}) : {}; -- 2.47.3