From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C5A7B1FF142 for ; Mon, 02 Mar 2026 13:28:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 351131E111; Mon, 2 Mar 2026 13:29:06 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager] resources: Expand max_restart option Date: Mon, 2 Mar 2026 13:28:18 +0100 Message-ID: <20260302122831.319795-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772454488942 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 23ZIEIIRCLMRMLXPDEZESRSHOBN4FMVS X-Message-ID-Hash: 23ZIEIIRCLMRMLXPDEZESRSHOBN4FMVS X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When read next to `max_relocate` it is not clear which happens first after a service fails to start. Signed-off-by: Maximiliano Sandoval --- When writting I initially had "When reached, the service will be attempted to be relocated" since it was clear it had to be on a "node" but as per HA rules not all of them might be eligible or some of them might already have reached the max_restart limit. src/PVE/HA/Resources.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm index 68d9d16..66dd7b4 100644 --- a/src/PVE/HA/Resources.pm +++ b/src/PVE/HA/Resources.pm @@ -73,7 +73,8 @@ EODESC }, max_restart => { description => "Maximal number of tries to restart the service on" - . " a node after its start failed.", + . " a node after its start failed. When reached, the service will be attempted to" + . " be relocated on an eligible node.", type => 'integer', optional => 1, default => 1, -- 2.47.3