From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B2AFC1FF141 for ; Fri, 27 Feb 2026 15:46:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3A757148E8; Fri, 27 Feb 2026 15:47:49 +0100 (CET) Date: Fri, 27 Feb 2026 15:47:42 +0100 From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Subject: superseded: [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot Message-ID: <20260227154742.1e54b55e@rosa.proxmox.com> In-Reply-To: References: <20260225183621.201783-1-s.ivanov@proxmox.com> <5182dc93-3a02-4cc9-8e02-dfb6959ef00d@proxmox.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772203643831 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.995 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.158 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.306 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.668 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HYI6YJN3RF523X3J3NA76KXZFIGGXVA4 X-Message-ID-Hash: HYI6YJN3RF523X3J3NA76KXZFIGGXVA4 X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 27 Feb 2026 09:00:23 +0100 Daniel Herzig wrote: > On 2/26/26 2:39 PM, Daniel Herzig wrote: > > thanks -- works as expected for my RAIDz1 2-disk setup! =20 >=20 > For if anyone wonders -- there's a 'z' that sneaked in here. I initially= =20 > tested against a ZFS RAID 1 two-disk mirror. >=20 > Just to make sure, I now also tested against a ZFS RAIDz-1 three-disk=20 > installation. As expected, the patch works fine for that as well. >=20 >=20 > > > > Although not in the scope of this patch, I want to note that the entry= =20 > > is not created for ZFS GRUB installations=C2=A0(be it on legacy non-EFI= , or=20 > > secure-boot EFI), as opposed to LVM GRUB installations. > > > > Tested-by: Daniel Herzig Thank you all for testing this so quickly - sent a new version (with bug-reference and grub-handling): https://lore.proxmox.com/pve-devel/20260227144336.3029652-1-s.ivanov@proxmo= x.com/T/#u > > > > On 2/25/26 7:37 PM, Stoiko Ivanov wrote: =20 > >> memtest86+ ships a config-snippet for grub configuration, and is thus > >> present on installations using grub (although currently not functional > >> when secure-boot is enabled). > >> > >> adding an equivalent entry for memtest86+ on systemd-booted systems > >> seems like an improvment and a step to having similar functionality in > >> our different boot-loader setups. > >> > >> Tested by installing proxmox-kernel-helper with this patch and running > >> proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a > >> systemd-booted system. > >> > >> Suggested-by: Daniel Herzig > >> Signed-off-by: Stoiko Ivanov > >> --- > >> not 100% sure if it's worth adding, but both Daniel and I thought=20 > >> this might > >> exist and I remember missing it once on a host of mine > >> > >> =C2=A0 src/bin/proxmox-boot-tool | 11 +++++++++++ > >> =C2=A0 1 file changed, 11 insertions(+) > >> > >> diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool > >> index 95d699d..b785c7d 100755 > >> --- a/src/bin/proxmox-boot-tool > >> +++ b/src/bin/proxmox-boot-tool > >> @@ -196,6 +196,17 @@ init_bootloader() { > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp" > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 echo "default proxmox-*" >> "$esp_mp/$PMX_LOADER_CONF.tmp" > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 mv "$esp_mp/$PMX_LOADER_CONF.tmp"=20 > >> "$esp_mp/$PMX_LOADER_CONF" > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 me= mtest=3Dmemtest86+x64.efi > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 me= mtest_conf=3D"$esp_mp/loader/entries/$memtest.conf" > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if= [ -f "/boot/$memtest" ]; then > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 echo "Adding $memtest .." > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 cp "/boot/$memtest" "$esp_mp/EFI/" > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 cat > "$memtest_conf.tmp" <<- EOF > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 title Memory test ($memtest) > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 efi=C2=A0=C2=A0 /EFI/$memtest > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 EOF > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 mv "$memtest_conf.tmp" "$memtest_conf" > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fi > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fi > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 echo "Installin= g grub i386-pc target.." =20 > > > > > > > > =20