From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 352261FF13B for ; Wed, 25 Feb 2026 16:20:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D46D084E8; Wed, 25 Feb 2026 16:20:25 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES qemu-server/guest-common/container v2 00/14] migration: strict config check for intra-cluster migration Date: Wed, 25 Feb 2026 16:18:23 +0100 Message-ID: <20260225151931.176335-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772032764080 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JQJ3S3N5UZZY74PBKD5VD5WB5DDLUWGE X-Message-ID-Hash: JQJ3S3N5UZZY74PBKD5VD5WB5DDLUWGE X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Changes in v2: * add patches for container * log when skipping strict configuration check For remote migration, we already check that the config can be parsed on the target. Do the same for intra-cluster migration, to avoid issues like [0] for future new settings, with settings being unexpectedly ignored on the target, and in the case of qemu-server even relatively silently dropped (there are warnings in the target's system logs). In case of containers, an example is migrating a container with a mountpoint with 'keepattrs' to a node with a too old pve-container version, resulting in the mountpoint not being mounted on the target. The first few patches for each repository are cleanups/tiny improvements that would be nice to have in any case. Unfortunately, before patch "qm: mtunnel: reply when a command is unknown", when a command is unknown, mtunnel did not reply at all. Therefore, this delays VM backwards migrations to qemu-server versions less than the next bumped version (at the time of this writing expected to be 9.1.5) by 3 seconds. I opted for 3 seconds, since config parsing should be very quick and 5 seconds would still be very noticeable for a bulk migration of VMs on a shared storage with a fast network. Right now, the option won't help anyways, only once we add a new config option (at which point we could bump it to 5 seconds). For containers, an 'mtunnel' endpoint is added and changes to stderr handling for the tunnel are useful, see guest-common patch "tunnel: redirect stderr to log function". [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=7341 Dependency bump pve-container -> guest-common needed! qemu-server: Fiona Ebner (6): d/control: bump versioned build dependency for libpve-common-perl to 9.0.12 tests: migration: get rid of mocking for removed PVE::QemuMigrate::read_tunnel() qm: mtunnel: avoid using deprecated check_running() helper mtunnel: add 'conf' command to do strict configuration parsing qm: mtunnel: reply when a command is unknown migration: intra-cluster: check config can be parsed on target node debian/control | 2 +- src/PVE/API2/Qemu.pm | 4 +++- src/PVE/CLI/qm.pm | 21 +++++++++++++++--- src/PVE/QemuMigrate.pm | 27 +++++++++++++++++++++++ src/test/MigrationTest/QemuMigrateMock.pm | 14 ++++++++---- 5 files changed, 59 insertions(+), 9 deletions(-) guest-common: Fiona Ebner (3): tunnel: add missing IO::File module import tunnel: end module with true value as recommended by perlcritic tunnel: redirect stderr to log function src/PVE/Tunnel.pm | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) container: Fiona Ebner (5): pct: add missing module imports and group according to style guide migrate: add missing module imports pct: introduce mtunnel command d/control: bump versioned build dependency for libpve-common-perl to 9.0.12 migration: intra-cluster: check config can be parsed on target node debian/control | 2 +- src/PVE/API2/LXC.pm | 11 ++++++++ src/PVE/CLI/pct.pm | 64 +++++++++++++++++++++++++++++++++++++++++- src/PVE/LXC/Migrate.pm | 41 +++++++++++++++++++++++++++ 4 files changed, 116 insertions(+), 2 deletions(-) Summary over all repositories: 10 files changed, 192 insertions(+), 14 deletions(-) -- Generated by git-murpp 0.5.0