From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 536091FF13B for ; Wed, 25 Feb 2026 14:05:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8ED9A6BE; Wed, 25 Feb 2026 14:06:52 +0100 (CET) From: Dominik Rusovac To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox] resource-scheduling: topsis: add context to 'unwraps' Date: Wed, 25 Feb 2026 14:06:39 +0100 Message-ID: <20260225130639.282334-1-d.rusovac@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772024790269 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.113 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.358 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.659 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AB3QMFXQTV5X3A6VFTQAXK5R7EZ3QC7Z X-Message-ID-Hash: AB3QMFXQTV5X3A6VFTQAXK5R7EZ3QC7Z X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Adds context as to why particular 'unwraps' panic. Signed-off-by: Dominik Rusovac --- proxmox-resource-scheduling/src/topsis.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/proxmox-resource-scheduling/src/topsis.rs b/proxmox-resource-scheduling/src/topsis.rs index 6d078aa6..25934f5b 100644 --- a/proxmox-resource-scheduling/src/topsis.rs +++ b/proxmox-resource-scheduling/src/topsis.rs @@ -145,8 +145,10 @@ impl IdealAlternatives { let min = fixed_criterion .clone() .min_by(|a, b| a.total_cmp(b)) - .unwrap(); - let max = fixed_criterion.max_by(|a, b| a.total_cmp(b)).unwrap(); + .expect("zero alternatives"); + let max = fixed_criterion + .max_by(|a, b| a.total_cmp(b)) + .expect("zero alternatives"); (best[n], worst[n]) = match criteria[n].maximize { true => (max, min), @@ -234,8 +236,7 @@ macro_rules! criteria_struct { $( $crate::topsis::Criterion::new($crit_name.to_string(), $crit_weight), )* - ]) - .unwrap() + ]).unwrap_or_else(|err| panic!("constructing criteria failed: {err}")) }); impl From<$name> for [f64; $count_name] { -- 2.47.3