From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0EF4D1FF139 for ; Tue, 24 Feb 2026 10:14:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C2D471F9EA; Tue, 24 Feb 2026 10:14:58 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox{,-backup} v3 00/22] partially fix #6563: add s3 request and traffic counter statistics Date: Tue, 24 Feb 2026 10:13:44 +0100 Message-ID: <20260224091406.169080-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771924446318 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.179 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.717 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.236 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: A2MSV2PGD3QFLSCKYP2ASZBTA2COODHE X-Message-ID-Hash: A2MSV2PGD3QFLSCKYP2ASZBTA2COODHE X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This patch series implements request and traffic counters for the s3 client, being shared as atomic counters via shared memory and mmapping across all s3-client instances. The shared counters are instantiated on demand for individual datastores with s3 backend on s3 client instantiation and stored as part of the datastore implementation by loading the mmapped file on datastore instantiation, being cached for further access. Further, counters are being loaded during rrd metrics collection and exposed as charts in the datastore summary, including the total request counts per method, the total upload and download traffic as well as the averaged upload and download rate. Usage statistics, soft limit and thresholds to send warnings via the notificatoin system are not included in this series an will be tackled as followup series. Link to the bugtracker issue: https://bugzilla.proxmox.com/show_bug.cgi?id=6563 Changes since version 2: - Introduce msync flushing mechanism to periodically persist counters state to mmap backing file. Changes since version 1 (thanks @Robert for feedback): - Keep tmpfs check in shmem mapping for pre-existing code, add dedicated methods to create mmapped files in persistent locations. - Reorder and align atomic counters to 32-byte (half default cache line size) to reduce false sharing. - Rework request counter init logic, avoid unsafe code and undefined behaviour. - Rework page size calculation based on new counter alignment. - Avoid the need to open and mmap counter file for each rrd data collection, keep the per-datastores filehandle cached instead. proxmox: Christian Ebner (10): proxmox-sys: expose msync to flush mmapped contents to filesystem shared-memory: add method without tmpfs check for mmap file location shared-memory: expose msync to flush in-memory contents to filesystem s3-client: add persistent shared request counters for client s3-client: add counters for upload/download traffic s3-client: account for upload traffic on successful request sending s3-client: account for downloaded bytes in incoming response body s3-client: request counters: periodically persist counters to file s3-client: sync flush request counters on client instance drop pbs-api-types: define api type for s3 request statistics pbs-api-types/src/datastore.rs | 28 ++ proxmox-s3-client/Cargo.toml | 6 + proxmox-s3-client/debian/control | 3 + proxmox-s3-client/examples/s3_client.rs | 1 + proxmox-s3-client/src/client.rs | 101 ++++- proxmox-s3-client/src/lib.rs | 7 +- proxmox-s3-client/src/response_reader.rs | 75 +++- .../src/shared_request_counters.rs | 410 ++++++++++++++++++ proxmox-shared-memory/src/lib.rs | 48 +- proxmox-sys/src/mmap.rs | 12 + 10 files changed, 671 insertions(+), 20 deletions(-) create mode 100644 proxmox-s3-client/src/shared_request_counters.rs proxmox-backup: Christian Ebner (12): metrics: split common module imports into individual use statements datastore: collect request statistics for s3 backed datastores datastore: expose request counters for s3 backed datastores api: s3: add endpoint to reset s3 request counters bin: s3: expose request counter reset method as cli command datastore: add helper method to get datastore backend type ui: improve variable name indirectly fixing typo ui: datastore summary: move store to be part of summary panel ui: expose s3 request counter statistics in the datastore summary metrics: collect s3 datastore statistics as rrd metrics api: admin: expose s3 statistics in datastore rrd data partially fix #6563: ui: expose s3 rrd charts in datastore summary pbs-datastore/src/datastore.rs | 66 +++- pbs-datastore/src/lib.rs | 2 +- src/api2/admin/datastore.rs | 23 +- src/api2/admin/s3.rs | 86 ++++- src/api2/config/s3.rs | 18 +- src/bin/proxmox_backup_manager/s3.rs | 33 ++ src/server/metric_collection/metric_server.rs | 8 +- src/server/metric_collection/mod.rs | 108 +++++- src/server/metric_collection/pull_metrics.rs | 18 +- src/server/metric_collection/rrd.rs | 34 +- www/datastore/Summary.js | 341 ++++++++++++------ 11 files changed, 587 insertions(+), 150 deletions(-) Summary over all repositories: 21 files changed, 1258 insertions(+), 170 deletions(-) -- Generated by murpp 0.9.0