From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B589F1FF139 for ; Tue, 24 Feb 2026 09:56:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3C4CA1ED8A; Tue, 24 Feb 2026 09:57:39 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH widget-toolkit] fix regression in checkcolumn rendering Date: Tue, 24 Feb 2026 09:55:22 +0100 Message-ID: <20260224085733.594116-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -1.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.179 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.717 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.236 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JZWXNUHH6M4JP6IUZ2XJXXXPAE7QMQ6Z X-Message-ID-Hash: JZWXNUHH6M4JP6IUZ2XJXXXPAE7QMQ6Z X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: in commit 57cd471f79ecd6b98c9cadb600ba0255360980fe the default column renderer was changed to Ext.htmlEncode, so that by default, we don't return raw HTML there anymore. The 'checkcolumn' relies on that behavior though, so we have to reset the renderer there to 'undefined' for it to work properly. This fixes all uses of 'checkcolumn', for example the enabled column in the boot order edit window for virtual machines. Fixes: 57cd471 (prevent interpreting of HTML in column grids by default) Signed-off-by: Dominik Csapak --- src/Toolkit.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/Toolkit.js b/src/Toolkit.js index d4e579b..bdfadf8 100644 --- a/src/Toolkit.js +++ b/src/Toolkit.js @@ -769,12 +769,21 @@ Ext.define('Proxmox.Cookies', { // Prevents html entities to be interpreted by the browser in grid columns by // default. Custom renderer have to take care of this by themselves. +// +// Reset the renderer for the 'checkcolumn' back to undefined, since it relies +// on the renderer returning raw HTML. Ext.define('Proxmox.grid.column.Column', { override: 'Ext.grid.column.Column', renderer: Ext.htmlEncode, }); +Ext.define('Proxmox.grid.column.Check', { + override: 'Ext.grid.column.Column', + + renderer: undefined, +}); + // force alert boxes to be rendered with an Error Icon // since Ext.Msg is an object and not a prototype, we need to override it // after the framework has been initiated -- 2.47.3