From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9E9BE1FF136 for ; Mon, 23 Feb 2026 16:25:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9FAD0110B9; Mon, 23 Feb 2026 16:26:35 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH manager v4 5/6] ui: qemu: hardware: efi: allow enrolling UEFI 2023 certs from Microsoft Date: Mon, 23 Feb 2026 16:25:37 +0100 Message-ID: <20260223152556.197761-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260223152556.197761-1-f.ebner@proxmox.com> References: <20260223152556.197761-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771860345505 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.798 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.79 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.547 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PYULZJ5R345CZKNJVXCQCHQZECOMFS4X X-Message-ID-Hash: PYULZJ5R345CZKNJVXCQCHQZECOMFS4X X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When the following conditions are met: - no pending change on the EFI disk - EFI disk has pre-enrolled-keys - There is no ms-cert=2023k marker yet suggest enrolling the new UEFI 2023 certificates from Microsoft. The previous 'Microsoft UEFI CA 2011' and the 'Microsoft Corporation KEK CA 2011' will expire in June 2026 and the previous 'Windows UEFI CA 2011' will expire in October 2026, so there needs to be an easy way to update. Note that this also detects drives with 'ms-cert=2023' and 'ms-cert=2023w' as still needing enrollment, because they do not yet include the 'Windows UEFI CA 2023' certificate and/or not include the 2023 KEK. Signed-off-by: Fiona Ebner --- Changes in v4: * use 2023k instead of 2023w www/manager6/qemu/HardwareView.js | 89 ++++++++++++++++++++++++++++++- 1 file changed, 88 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index cf5e2a0f..e9f84b51 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -442,6 +442,38 @@ Ext.define('PVE.qemu.HardwareView', { handler: run_editor, }); + let runEfiEnroll = function () { + let rec = sm.getSelection()[0]; + if (!rec) { + return; + } + + let efidisk = PVE.Parser.parsePropertyString(rec.data.value, 'file'); + efidisk['ms-cert'] = '2023k'; + + let params = {}; + params[rec.data.key] = PVE.Parser.printPropertyString(efidisk); + Proxmox.Utils.API2Request({ + url: `/api2/extjs/${baseurl}`, + waitMsgTarget: me, + method: 'POST', + params: params, + callback: () => me.reload(), + failure: (response) => Ext.Msg.alert('Error', response.htmlStatus), + success: function (response, options) { + if (response.result.data !== null) { + Ext.create('Proxmox.window.TaskProgress', { + autoShow: true, + upid: response.result.data, + listeners: { + destroy: () => me.reload(), + }, + }); + } + }, + }); + }; + let move_menuitem = new Ext.menu.Item({ text: gettext('Move Storage'), tooltip: gettext('Move disk to another storage'), @@ -510,11 +542,55 @@ Ext.define('PVE.qemu.HardwareView', { }, }); + const efiEnrollMsg = + gettext( + 'Enroll the UEFI 2023 certificates from Microsoft required for secure boot update.', + ) + + '
' + + gettext('This is also needed for secure boot update for common Linux distributions.') + + '
' + + '
' + + gettext('For Windows with BitLocker, run the following command inside Powershell:') + + '
manage-bde -protectors -disable <drive>
' + + Ext.String.format( + // TRANSLATORS: for a shell command: "placeholder could be 'concrete value'" + gettext("For example, {0} could be '{1}'."), + '<drive>', + 'C:', + ) + + '
' + + gettext('This is required for each drive with BitLocker before proceeding!') + + '
' + + gettext( + 'Otherwise, you will be prompted for the BitLocker recovery key on the next boot!', + ); + let efiEnrollMenuItem = new Ext.menu.Item({ + text: gettext('Enroll Updated Certificates'), + iconCls: 'fa fa-refresh', + selModel: sm, + disabled: true, + hidden: true, + handler: () => { + Ext.Msg.show({ + title: gettext('Confirm'), + icon: Ext.Msg.QUESTION, + message: efiEnrollMsg, + buttons: Ext.Msg.YESNO, + callback: function (btn) { + if (btn !== 'yes') { + return; + } + runEfiEnroll(); + }, + }); + }, + }); + let diskaction_btn = new Proxmox.button.Button({ text: gettext('Disk Action'), disabled: true, menu: { - items: [move_menuitem, reassign_menuitem, resize_menuitem], + items: [move_menuitem, reassign_menuitem, resize_menuitem, efiEnrollMenuItem], }, }); @@ -686,6 +762,17 @@ Ext.define('PVE.qemu.HardwareView', { ); remove_btn.RESTMethod = isUnusedDisk || (isDisk && isRunning) ? 'POST' : 'PUT'; + let suggestEfiEnroll = false; + if (isEfi) { + let drive = PVE.Parser.parsePropertyString(value, 'file'); + suggestEfiEnroll = + !pending && + PVE.Parser.parseBoolean(drive['pre-enrolled-keys'], false) && + drive['ms-cert'] !== '2023k'; + } + efiEnrollMenuItem.setDisabled(!suggestEfiEnroll); + efiEnrollMenuItem.setHidden(!isEfi); + edit_btn.setDisabled( deleted || !row.editor || -- 2.47.3