From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B9A261FF136 for ; Mon, 23 Feb 2026 11:01:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 940686C9E; Mon, 23 Feb 2026 11:02:30 +0100 (CET) Date: Mon, 23 Feb 2026 11:02:14 +0100 From: Stoiko Ivanov To: Stefan Mayr Subject: Re: [PATCH common v3 0/2] Fix #7175: replace timezone handling with systemd timedatectl Message-ID: <20260223110214.363a12c8@rosa.proxmox.com> In-Reply-To: <20260222110205.582-1-stefan@mayr-stefan.de> References: <20260220124809.076116bb@rosa.proxmox.com> <20260222110205.582-1-stefan@mayr-stefan.de> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771840930367 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.998 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.798 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.79 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.547 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GQBB36WCZE5DMYP6EZUQ3I6SKQZNUZNR X-Message-ID-Hash: GQBB36WCZE5DMYP6EZUQ3I6SKQZNUZNR X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the quick iteration on this! For reference: These 2 patches replace PATCH 4/4 from: https://lore.proxmox.com/pve-devel/20260125210151.1151-5-stefan@mayr-stefan.de/ The idea being that patch 1/2 is applied first - then the patches for pve-container, pve-manager, pmg-api, with a versioned dependency bump on libpve-common-perl. Once this is rolled PATCH 2/2 from this series can be applied as well (breaking pve-container, pve-manager, pmg-api not containing the patches from the v2). 3 tiny nits, which are mostly for any future patches - the complete series is fine as is IMO. nit: I'd use different first line for the commit message of each patch e.g.: 1/2: fix #7175: add timezonectl helpers to PVE::Systemd 2/2: fix #7175: drop deprecated /etc/timezone file helpers this can be fixed up on applying. nit: sending the complete series again (even if patches for the other repositories did not change at all) helps in having all needed things in one thread - the duplicate mails are less of a problem. nit: it seems you set my e-mail as reply-to header for this series (this should not be an issue, as most people hit "Reply All" in their mail-clients anyway, but could cause some confusion) - maybe you wanted to add me in CC (`--cc s.ivanov@proxmox.com` for git send-email)? As the 2 patches together here amount to the same result as the patch for pve-common in the v2 - my: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov still applies (and I quickly checked applying only patch 1/2 on a test-vm of mine) Thanks again for your work on this and making the effort to address the feedback - much appreciated! stoiko On Sun, 22 Feb 2026 12:02:03 +0100 Stefan Mayr wrote: > This splits the patch to pve-common into two parts: > 1. adds functions for systemd timedatectl > 2. removes handling deprecated /etc/timezone from INotify module > > > >