From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 495B71FF13E for ; Fri, 20 Feb 2026 12:47:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4826E5AA8; Fri, 20 Feb 2026 12:48:17 +0100 (CET) Date: Fri, 20 Feb 2026 12:48:09 +0100 From: Stoiko Ivanov To: Stefan Mayr Subject: Re: [pve-devel] [PATCH common, container, manager and pmg-api v2 0/4] Fix #7175: replace timezone handling with systemd timedatectl Message-ID: <20260220124809.076116bb@rosa.proxmox.com> In-Reply-To: <20260125210151.1151-1-stefan@mayr-stefan.de> References: <20260125210151.1151-1-stefan@mayr-stefan.de> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771588079870 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6V4VZU6TMRDWLO7ZQO7LZGZH4HTZAKSA X-Message-ID-Hash: 6V4VZU6TMRDWLO7ZQO7LZGZH4HTZAKSA X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Proxmox VE development discussion X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the patches, and your continued effort! Changes look good to me in principle.=20 Gave the series a test-run on a PVE 9 and a PMG 9 - it works as advertised. comments inline: On Sun, 25 Jan 2026 22:01:47 +0100 Stefan Mayr wrote: > Second try to fix #7175. These patches remove direct /etc/timezone > handling, add timezone functions to the Systemd module and replaces all > uses of the functions you pointed me to. >=20 > This time it is with a verification of valid timezones. >=20 > It does not address hardcoded timezones in the javascript for the UI or > the rust code handling timezones. Replacing the hardcoded list in our frontend-code with a call to an API-method, which wraps your PVE::Systemd::list_timezones seems like a good further improvement. Regarding the rust side of our code and products - from a quick check those do fall-back to `/etc/localtime` if `/etc/timezone` is not available: PDM: https://git.proxmox.com/?p=3Dproxmox-datacenter-manager.git;a=3Dblob;f=3Dse= rver/src/api/nodes/time.rs;h=3D7f711c95ecd0b810fda360212d1c38a77093c920;hb= =3Dd5bfa9b8fa429cfed57dc9a1528e7662ff4c787f uses proxmox-time-api: https://git.proxmox.com/?p=3Dproxmox.git;a=3Dblob;f=3Dproxmox-time-api/src/= time_impl.rs;h=3D383bae1168eaab2d503c8da609c532d0974bc0b9;hb=3DHEAD (although writing /etc/timezone could also be done only conditionally (on its existence), and dropped with the next debian-release[0].) PBS has its own implementation: https://git.proxmox.com/?p=3Dproxmox-backup.git;a=3Dblob;f=3Dsrc/api2/node/= time.rs;h=3Dd7ca10e31a14332b384518a03b270a7706b1538e;hb=3DHEAD (which looks equal to the one in proxmox-time api and could also be replaced by that from a quick look). But none of the suggested future improvements are needed for this - so they can be done independently (by you, if you're interested, else someone here can take that part). Splitting the pve-common patch - one introducing the new helpers (and adding a comment that the ones in PVE::INotify are deprecated), and a second one actually dropping the old ones, would make this easier to roll-out (no need to roll out all call-sites (pve-container, pve-manager, pmg-api) at the same time, to each of our repositories). apart from the splitting of the patch for pve-common, consider this: Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov >=20 > Trying to provide patches to Proxmox is the first time I have to use > an email based patch workflow. I'm pretty sure sending these patches for > four different repos the way I do it currently is not 100% how it is > intended to be done. So please forgive me. >=20 > Suggested-by: Fabian Gr=C3=BCnbichler > Suggested-by: Maximiliano Sandroval > Signed-off-by: Stefan Mayr [0] forky will remove /etc/timezone unconditionally, while /etc/localtime remains: https://metadata.ftp-master.debian.org/changelogs//main/t/tzdata/tzdata_202= 5c-3_changelog