From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 165C21FF13E for ; Fri, 20 Feb 2026 13:37:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5ED8C78BE; Fri, 20 Feb 2026 13:38:23 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Subject: [PATCH backup v2 0/3] fix #7054: client: remove trailing newlines from credentials Date: Fri, 20 Feb 2026 13:38:13 +0100 Message-ID: <20260220123818.365489-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771591087683 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YED4QOTELIXZBOJ2VQU35RMG5K3JUX4T X-Message-ID-Hash: YED4QOTELIXZBOJ2VQU35RMG5K3JUX4T X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: See the first commit for more details. This was tested with proxmox-backup-client making a login/backup using different credentials with and without newlines. The commands were similar to the systemd-run commands at the Backup Client Usage docs. I did not find a way to create the keyfile with newlines in its password using proxmox-backup-client since it reads from the tty stdin, but surely it could be created manually. Perhaps it is safe-ish to also remove trailing control characters from the encryption password but this seems a safer approach for now. Diferences from v1: - Always do an extra allocation to keep the code clean - Rename password to blob - Only strip newlines on passwords Maximiliano Sandoval (3): fix #7054: client: remove trailing newlines from credentials docs: client: document further password constrains client: rename password to blob docs/backup-client.rst | 7 ++++--- pbs-client/src/tools/mod.rs | 14 ++++++++++++-- 2 files changed, 16 insertions(+), 5 deletions(-) -- 2.47.3