From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E2F541FF13C for ; Thu, 19 Feb 2026 16:25:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AF2A31BD01; Thu, 19 Feb 2026 16:26:25 +0100 (CET) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network v2 2/2] sdn: controllers: rename isis domain to fabric_id Date: Thu, 19 Feb 2026 16:25:27 +0100 Message-ID: <20260219152544.427439-8-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260219152544.427439-1-g.goller@proxmox.com> References: <20260219152544.427439-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771514741500 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: I3CEPHGTGILT4JL3QHLQ6RSJZMZD6P5T X-Message-ID-Hash: I3CEPHGTGILT4JL3QHLQ6RSJZMZD6P5T X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Rename the "domain" property to "fabric_id" in the ISIS controller to align with the ISIS fabric naming convention and enable sharing of proxmox-frr ISIS types between both components. The ISIS fabric and ISIS controller share basic configuration options, but previously used different property names ("fabric_id" vs "domain"). Since fabrics are hardcoded to use "fabric_id", standardize the controller to use the same naming. This change is backwards compatible as: 1) The template series has not yet been merged and will likely merge alongside this series 2) It is unlikely that libpve-rs-perl and libpve-network-perl would become out of sync Signed-off-by: Gabriel Goller --- src/PVE/Network/SDN/Controllers/IsisPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Controllers/IsisPlugin.pm b/src/PVE/Network/SDN/Controllers/IsisPlugin.pm index 454bdda6d316..81aef2de7e24 100644 --- a/src/PVE/Network/SDN/Controllers/IsisPlugin.pm +++ b/src/PVE/Network/SDN/Controllers/IsisPlugin.pm @@ -87,7 +87,7 @@ sub generate_frr_config { for my $iface (sort @ifaces) { my $iface_name = $altnames->{$iface} // $iface; $config->{frr}->{isis}->{interfaces}->{$iface_name} //= {}; - $config->{frr}->{isis}->{interfaces}->{$iface_name}->{domain} = $isis_domain; + $config->{frr}->{isis}->{interfaces}->{$iface_name}->{fabric_id} = $isis_domain; $config->{frr}->{isis}->{interfaces}->{$iface_name}->{is_ipv4} = 1; $config->{frr}->{isis}->{interfaces}->{$iface_name}->{is_ipv6} = 0; } -- 2.47.3