From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 835EB1FF13C for ; Thu, 19 Feb 2026 16:24:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 36B0F1B464; Thu, 19 Feb 2026 16:25:55 +0100 (CET) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-perl-rs v2 1/2] pve-rs: fabrics: add IS-IS protocol ifupdown config generation Date: Thu, 19 Feb 2026 16:25:24 +0100 Message-ID: <20260219152544.427439-5-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260219152544.427439-1-g.goller@proxmox.com> References: <20260219152544.427439-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771514741322 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FC6ESTP7ONVGTVERSEONXENOTQ74NFMD X-Message-ID-Hash: FC6ESTP7ONVGTVERSEONXENOTQ74NFMD X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Generate the interfaces that have been configured with IS-IS to the ifupdown config (enable ip-forwarding on all). IS-IS needs to have the ip-address duplicated from the dummy interface to every interface in unnumbered mode (like with ospf). This could potentially be fixed in the future with [0]. [0]: https://github.com/FRRouting/frr/pull/19429 Signed-off-by: Gabriel Goller --- pve-rs/src/bindings/sdn/fabrics.rs | 44 ++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/pve-rs/src/bindings/sdn/fabrics.rs b/pve-rs/src/bindings/sdn/fabrics.rs index 18848c405201..c4150c830a0a 100644 --- a/pve-rs/src/bindings/sdn/fabrics.rs +++ b/pve-rs/src/bindings/sdn/fabrics.rs @@ -354,6 +354,13 @@ pub mod pve_rs_sdn_fabrics { } } } + ConfigNode::Isis(node_section) => { + for interface in node_section.properties_mut().interfaces_mut() { + if let Some(mapped_name) = map_name(&mapping, interface.name())? { + interface.set_name(mapped_name); + } + } + } ConfigNode::Ospf(node_section) => { for interface in node_section.properties_mut().interfaces_mut() { if let Some(mapped_name) = map_name(&mapping, interface.name())? { @@ -453,6 +460,9 @@ pub mod pve_rs_sdn_fabrics { FabricEntry::Openfabric(_) => { daemons.insert("fabricd"); } + FabricEntry::Isis(_) => { + daemons.insert("isisd"); + } }; } @@ -547,6 +557,40 @@ pub mod pve_rs_sdn_fabrics { } } } + ConfigNode::Isis(node_section) => { + for interface in node_section.properties().interfaces() { + if let Some(ip) = interface.ip() { + let interface = + render_interface(interface.name(), Cidr::from(ip), false)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + if let Some(ip) = interface.ip6() { + let interface = + render_interface(interface.name(), Cidr::from(ip), false)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + + // If no ip is configured, add auto and iface with node ip to bring + // interface up ISIS doesn't really need an ip on the interface, but the + // problem is that arp can't tell which source address to use in some + // cases, so it's better if we set the node address on all the fabric + // interfaces. + if let (None, None) = (interface.ip(), interface.ip6()) { + let cidr = Cidr::from(if let Some(ip) = node.ip() { + IpAddr::from(ip) + } else if let Some(ip) = node.ip6() { + IpAddr::from(ip) + } else { + anyhow::bail!("there has to be a ipv4 or ipv6 node address"); + }); + let interface = render_interface(interface.name(), cidr, false)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + } + } ConfigNode::Ospf(node_section) => { for interface in node_section.properties().interfaces() { if let Some(ip) = interface.ip() { -- 2.47.3