From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9D40F1FF138 for ; Wed, 18 Feb 2026 15:29:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CDC51E87E; Wed, 18 Feb 2026 15:30:36 +0100 (CET) From: Manuel Federanko To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server] fix #5578: smbios: set serial number Date: Wed, 18 Feb 2026 15:29:35 +0100 Message-ID: <20260218142935.99693-1-m.federanko@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.102 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy HEADER_FROM_DIFFERENT_DOMAINS 0.001 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: W2QNJVE3JEYSCGQ6BLQZYOCSBMEF44DM X-Message-ID-Hash: W2QNJVE3JEYSCGQ6BLQZYOCSBMEF44DM X-MailFrom: mfederanko@pve.localdomain X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If no smbios options are given on creation, default to generate a serial number. This is required for Windows Autopilot to identify a user device. Signed-off-by: Manuel Federanko --- src/PVE/API2/Qemu.pm | 5 ++++- src/PVE/CLI/qm.pm | 5 ++++- src/PVE/QemuServer.pm | 6 ++++++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index c2e185a6..8d1e3ec0 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -1471,7 +1471,10 @@ __PACKAGE__->register_method({ # auto generate uuid if user did not specify smbios1 option if (!$conf->{smbios1}) { - $conf->{smbios1} = PVE::QemuServer::generate_smbios1_uuid(); + $conf->{smbios1} = + PVE::QemuServer::generate_smbios1_uuid() . "," + . PVE::QemuServer::generate_smbios1_serial() + . ",base64=1"; } if ( diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm index bdae9641..44c74eed 100755 --- a/src/PVE/CLI/qm.pm +++ b/src/PVE/CLI/qm.pm @@ -912,7 +912,10 @@ __PACKAGE__->register_method({ eval { # order matters, as do_import() will load_config() internally $conf->{vmgenid} = PVE::QemuServer::generate_uuid(); - $conf->{smbios1} = PVE::QemuServer::generate_smbios1_uuid(); + $conf->{smbios1} = + PVE::QemuServer::generate_smbios1_uuid() . "," + . PVE::QemuServer::generate_smbios1_serial() + . ",base64=1"; PVE::QemuConfig->write_config($vmid, $conf); foreach my $disk (@{ $parsed->{disks} }) { diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 545758dc..a8cc7d85 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -8086,6 +8086,12 @@ sub generate_smbios1_uuid { return "uuid=" . generate_uuid(); } +sub generate_smbios1_serial { + my @population = ('0' .. '9', 'A' .. 'Z', 'a' .. 'z'); + my $serial = join('', map($population[rand(@population)], 1 .. 12)); + return "serial=" . encode_base64($serial, ""); +} + sub create_reboot_request { my ($vmid) = @_; open(my $fh, '>', "/run/qemu-server/$vmid.reboot") -- 2.47.3