From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 08EEE1FF142 for ; Mon, 16 Feb 2026 13:14:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9548E10D89; Mon, 16 Feb 2026 13:15:01 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2 07/12] ui: improve variable name indirectly fixing typo Date: Mon, 16 Feb 2026 13:14:01 +0100 Message-ID: <20260216121406.99617-14-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260216121406.99617-1-c.ebner@proxmox.com> References: <20260216121406.99617-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771244055022 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NYU6F3SBYEVHV4DRT2TE4CFBJGTVKHWS X-Message-ID-Hash: NYU6F3SBYEVHV4DRT2TE4CFBJGTVKHWS X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: `lastRequestWasFailue` not only has a typo but is also not that easily readable, use `lastRequestFailed` instead. Signed-off-by: Christian Ebner --- changes since version 1: - no changes www/datastore/Summary.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js index cdb34aea3..cb412630d 100644 --- a/www/datastore/Summary.js +++ b/www/datastore/Summary.js @@ -394,12 +394,12 @@ Ext.define('PBS.DataStoreSummary', { interval: 1000, }); - let lastRequestWasFailue = false; + let lastRequestFailed = false; me.mon(me.statusStore, 'load', (s, records, success) => { let mountBtn = me.lookupReferenceHolder().lookupReference('mountButton'); let unmountBtn = me.lookupReferenceHolder().lookupReference('unmountButton'); if (!success) { - lastRequestWasFailue = true; + lastRequestFailed = true; me.statusStore.stopUpdate(); me.rrdstore.stopUpdate(); @@ -430,13 +430,13 @@ Ext.define('PBS.DataStoreSummary', { }); } else { // only trigger on edges, else we couple our interval to the info one - if (lastRequestWasFailue) { + if (lastRequestFailed) { me.down('pbsDataStoreInfo').fireEvent('activate'); me.rrdstore.startUpdate(); } unmountBtn.setDisabled(false); mountBtn.setDisabled(true); - lastRequestWasFailue = false; + lastRequestFailed = false; } }); -- 2.47.3