From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3202C1FF13E for ; Fri, 06 Feb 2026 17:12:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F14429BE4; Fri, 6 Feb 2026 17:12:42 +0100 (CET) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox v2 1/1] fix #7077: Improve SDN ID validation error messages Date: Fri, 6 Feb 2026 17:12:36 +0100 Message-ID: <20260206161236.335026-6-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260206161236.335026-1-a.bied-charreton@proxmox.com> References: <20260206161236.335026-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: ZUDIVB243XMDEKXIXWIE2LQUZLPKU7AM X-Message-ID-Hash: ZUDIVB243XMDEKXIXWIE2LQUZLPKU7AM X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The regexes for verifying SDN (controller)? IDs have implicit `length >= 2` constraints resulting in less-than-ideal error messages in case of length mismatch. Add explicit length checks before checking the regexes. Signed-off-by: Arthur Bied-Charreton --- pve-api-types/src/types/verifiers.rs | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/pve-api-types/src/types/verifiers.rs b/pve-api-types/src/types/verifiers.rs index c45063b5..f731f13b 100644 --- a/pve-api-types/src/types/verifiers.rs +++ b/pve-api-types/src/types/verifiers.rs @@ -266,7 +266,11 @@ pub fn verify_vlan_id_or_range(s: &str) -> Result<(), Error> { pub fn verify_sdn_id(s: &str) -> Result<(), Error> { if s.len() > 8 { - bail!("SDN ID cannot be longer than 8 characters") + bail!("SDN ID cannot be longer than 8 characters"); + } + + if s.len() < 2 { + bail!("SDN ID cannot be shorter than 2 characters"); } if !SDN_ID.is_match(s) { @@ -278,7 +282,11 @@ pub fn verify_sdn_id(s: &str) -> Result<(), Error> { pub fn verify_sdn_controller_id(s: &str) -> Result<(), Error> { if s.len() > 64 { - bail!("SDN controller ID cannot be longer than 64 characters") + bail!("SDN controller ID cannot be longer than 64 characters"); + } + + if s.len() < 2 { + bail!("SDN controller ID cannot be shorter than 2 characters"); } if !SDN_CONTROLLER_ID.is_match(s) { -- 2.47.3