From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B216A1FF13E for ; Fri, 06 Feb 2026 13:45:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CE0F1827; Fri, 6 Feb 2026 13:45:52 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH container v2 4/4] setup: make the architecture fall back to amd64 for falsy values Date: Fri, 6 Feb 2026 13:45:05 +0100 Message-ID: <20260206124513.310674-5-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260206124513.310674-1-d.kral@proxmox.com> References: <20260206124513.310674-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770381837300 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2RYHOAYOWEVXCGXMNBZ2C7MSDFZIKTVY X-Message-ID-Hash: 2RYHOAYOWEVXCGXMNBZ2C7MSDFZIKTVY X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The architecture fallback branch relied on detect_architecture(...) failing and therefore $arch being undef afterwards. However, if protected_call(sub { detect_architecture(...) }) itself returns a defined, falsy value, such as a empty string converted from an undef value, the 'arch' field will be set to that value, which will make the container fail to start. Therefore, fallback to 'amd64' for any falsy $arch value. Signed-off-by: Daniel Kral --- changes from v1: - adapt patch message regarding the protected_call(...) src/PVE/LXC/Setup.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm index 113093d..fb0207e 100644 --- a/src/PVE/LXC/Setup.pm +++ b/src/PVE/LXC/Setup.pm @@ -153,7 +153,7 @@ sub new { warn "Architecture detection failed: $err" if $err; } - if (!defined($arch)) { + if (!$arch) { $arch = 'amd64'; print "Falling back to $arch.\nUse `pct set VMID --arch ARCH` to change.\n"; } else { -- 2.47.3