From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EF41D1FF13E for ; Fri, 06 Feb 2026 12:35:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EBCEB25E6E; Fri, 6 Feb 2026 12:36:21 +0100 (CET) Date: Fri, 6 Feb 2026 12:35:41 +0100 From: Stoiko Ivanov To: Arthur Bied-Charreton Subject: Re: [pve-devel] [PATCH pve-cluster v2 0/3] fix #6701: Update PVE cert generation Message-ID: <20260206123541.2f8d6d2a@rosa.proxmox.com> In-Reply-To: <20260126100534.86882-3-a.bied-charreton@proxmox.com> References: <20260126100534.86882-3-a.bied-charreton@proxmox.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770377662671 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AD36GFZUYJV32OXGEDPJQDLEG5E5VWSF X-Message-ID-Hash: AD36GFZUYJV32OXGEDPJQDLEG5E5VWSF X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Proxmox VE development discussion X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the quick iteration on this! Changes look good to me - and I consider them an improvement to before. Tested this quickly by: 1) removing pve-root-ca (key and cert), the node's pve-ssl (key and cert) 2) running `pvecm updatecerts --force` 3) installing pve-cluster packages with your patches applied 4) recreating the certificate (point 1+2) again 5) vimdiffing old and new files - changes look sensible (apart from the uuid, only the added keyUsage extension) 6) running the test-script from your commit-message after restarting pveproxy did not read/recheck everything in RFC 5280 though. consider this series Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Mon, 26 Jan 2026 10:55:42 +0100 Arthur Bied-Charreton wrote: > The main fix (1/3) adds the keyUsage extension to PVE's root CA, which > is required by RFC 5280. > > {2,3}/3 address review feedback [1] by eliminating temporary config > files and moving temp file creation from /tmp to /run to prevent symlink > races. > > More details in the commit messages. > > [1] > https://lore.proxmox.com/pve-devel/20260123195300.0ae7fcc9@rosa.proxmox.com/T/#t > > Arthur Bied-Charreton (3): > fix #6701: Add keyUsage extension to root CA > Convert SSL cert generation config to CLI arguments > Create temporary CSR file in /run instead of /tmp > > src/PVE/Cluster/Setup.pm | 45 +++++++++++----------------------------- > 1 file changed, 12 insertions(+), 33 deletions(-) >