From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 285DF1FF138 for ; Wed, 04 Feb 2026 17:14:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8341D1A2A4; Wed, 4 Feb 2026 17:14:33 +0100 (CET) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox 5/5] notify: Add test for State Date: Wed, 4 Feb 2026 17:13:44 +0100 Message-ID: <20260204161354.458814-6-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260204161354.458814-1-a.bied-charreton@proxmox.com> References: <20260204161354.458814-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.130 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: CNMO4ZWLYWZO22C3TGSDTL6FIOCYSFAU X-Message-ID-Hash: CNMO4ZWLYWZO22C3TGSDTL6FIOCYSFAU X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add test verifying basic functionality and state persistence. Signed-off-by: Arthur Bied-Charreton --- proxmox-notify/src/lib.rs | 56 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs index 3bd83ce4..f4fd3aa2 100644 --- a/proxmox-notify/src/lib.rs +++ b/proxmox-notify/src/lib.rs @@ -683,10 +683,25 @@ mod tests { messages: Rc>>, } + #[derive(Default, Clone, Serialize, Deserialize)] + struct MockEndpointState { + notifications_sent: usize, + } + + impl EndpointState for MockEndpointState {} + impl Endpoint for MockEndpoint { - fn send(&self, message: &Notification, _: &mut State) -> Result<(), Error> { + fn send(&self, message: &Notification, state: &mut State) -> Result<(), Error> { + let endpoint_state = state.get_or_default::(self.name)?; self.messages.borrow_mut().push(message.clone()); + state.set( + self.name, + &MockEndpointState { + notifications_sent: endpoint_state.notifications_sent + 1, + }, + )?; + Ok(()) } @@ -791,4 +806,43 @@ mod tests { Ok(()) } + + #[test] + fn test_endpoint_with_state() -> Result<(), Error> { + let mut state = State::default(); + let mock = MockEndpoint::new("endpoint"); + + let mut bus = Bus::default(); + bus.add_endpoint(Box::new(mock.clone())); + + let matcher = MatcherConfig { + target: vec!["endpoint".into()], + ..Default::default() + }; + + bus.add_matcher(matcher); + + // Send directly to endpoint + bus.send( + &Notification::from_template( + Severity::Info, + "test", + Default::default(), + Default::default(), + ), + &mut state, + ); + + let endpoint_state = state.get::("endpoint")?.unwrap(); + + assert_eq!(endpoint_state.notifications_sent, 1); + + state.persist(context().state_file_path())?; + + let persisted_state = State::from_path(context().state_file_path())?; + + assert_eq!(state, persisted_state); + + Ok(()) + } } -- 2.47.3