From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 04D7B1FF138 for ; Wed, 04 Feb 2026 14:48:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AD5D614A1A; Wed, 4 Feb 2026 14:48:40 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-i18n v2 3/5] make: remove javascript-format flag from extracted strings Date: Wed, 4 Feb 2026 14:48:31 +0100 Message-ID: <20260204134835.422155-4-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260204134835.422155-1-m.sandoval@proxmox.com> References: <20260204134835.422155-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770212839860 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GSLIOSMK7EXJIZHN4OLBKX3K7ELLZAHB X-Message-ID-Hash: GSLIOSMK7EXJIZHN4OLBKX3K7ELLZAHB X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This provides a hint to gettext that the string uses javascript format [1], however the format described here does not match how Ext.String.format operates. Certain editors, e.g. GTranslator, might refuse to translate a string if the format on msgstr is broken, hence it is preferable to not have this flag. [1] https://www.gnu.org/software/gettext/manual/html_node/javascript_002dformat.html Signed-off-by: Maximiliano Sandoval --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 2e1312ea..31c49432 100644 --- a/Makefile +++ b/Makefile @@ -210,6 +210,7 @@ messages.pot: proxmox-widget-toolkit.pot proxmox-mailgateway.pot pve-manager.pot --msgid-bugs-address="" \ --copyright-holder="Copyright (C) Proxmox Server Solutions GmbH & the translation contributors." \ --output $@ + awk '!/#, javascript-format/' messages.pot > tmpfile && mv tmpfile messages.pot .PHONY: distclean distclean: clean -- 2.47.3