From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D73641FF138 for ; Wed, 04 Feb 2026 10:17:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F9D9DB4E; Wed, 4 Feb 2026 10:18:21 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH container 3/3] setup: make the architecture fall back to amd64 for empty strings Date: Wed, 4 Feb 2026 10:17:34 +0100 Message-ID: <20260204091740.102914-4-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260204091740.102914-1-d.kral@proxmox.com> References: <20260204091740.102914-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770196589905 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IBZRH46SK35FE3CP25AI7ZJWXJHNNOPJ X-Message-ID-Hash: IBZRH46SK35FE3CP25AI7ZJWXJHNNOPJ X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Otherwise, if the underlying detect_architecture(...) method returns any false value, the return value of the call to protected_call(...) will return an empty string. This sets the architecture to an empty string and will make the container fail to start. Signed-off-by: Daniel Kral --- src/PVE/LXC/Setup.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm index 113093d..fb0207e 100644 --- a/src/PVE/LXC/Setup.pm +++ b/src/PVE/LXC/Setup.pm @@ -153,7 +153,7 @@ sub new { warn "Architecture detection failed: $err" if $err; } - if (!defined($arch)) { + if (!$arch) { $arch = 'amd64'; print "Falling back to $arch.\nUse `pct set VMID --arch ARCH` to change.\n"; } else { -- 2.47.3