From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2092F1FF13E for ; Fri, 23 Jan 2026 18:29:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7C77012897; Fri, 23 Jan 2026 18:30:00 +0100 (CET) From: Shan Shaji To: pdm-devel@lists.proxmox.com Date: Fri, 23 Jan 2026 18:29:07 +0100 Message-ID: <20260123172910.244121-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769189306615 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.520 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_BADIPHTTP 2 Due to the Storm Bot Network, IPs in emails is bad KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NUMERIC_HTTP_ADDR 1.242 Uses a numeric IP address in URL RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [githubusercontent.com, proxmox.com, acme.rs, main.rs] WEIRD_PORT 0.001 Uses non-standard port number for HTTP Subject: [pdm-devel] [PATCH datacenter-manager 0/3] fix #7179: expose ACME commands inside admin CLI X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Previously, ACME commands were not exposed through the admin CLI. Added the necessary functionality to manage ACME settings directly via the command line. The changes are done by taking reference from the proxmox-backup codebase. Since i am using the completion handlers from the proxmox-acme-api crate the following patch [1] needs to be applied before testing or merging the changes of this patch series. **note**: Sending this series only for an initial review as the completions are not working and also to know if i have missed anything :). Testing ======= In general i have verified the following commands ie, - account (deactivate, info, list, update) - certificate (order, revoke) - plugin (add, config, list, remove, set) ### Certifcate Creation http-01 challenge: ----------------- I have tested the http-01 challenge verification using a test pebble server. Steps followed to test the changes: 1. Installed the changes inside a PDM VM. 2. install Pebble from Let's Encrypt [2] on the same VM: cd apt update apt install -y golang git git clone https://github.com/letsencrypt/pebble cd pebble go build ./cmd/pebble then, download and trust the Pebble cert: wget https://raw.githubusercontent.com/letsencrypt/pebble/main/test/certs/pebble.minica.pem cp pebble.minica.pem /usr/local/share/ca-certificates/pebble.minica.crt update-ca-certificates We want Pebble to perform HTTP-01 validation against port 80, because PDM's standalone plugin will bind port 80. Set httpPort to 80. nano ./test/config/pebble-config.json Start the Pebble server in the background: ./pebble -config ./test/config/pebble-config.json & Created a Pebble ACME account: proxmox-datacenter-manager-admin acme account register default admin@example.com --directory 'https://127.0.0.1:14000/dir' Added a new ACME domain pdm.proxmox.com with HTTP challenge type. Then ran the following command. proxmox-datacenter-manager admin acme certificate order --force true Checked if the certificate is validated by the pebble CA. Ran the revoke command and verified if the certificate is self-signed after force refresh. --- DNS-01 challenge: ---------------- I tested the changes with my domain using the cloudflare plugin. Steps followed to test the changes: 1. Created an ACME account using let's encrypt staging API. 2. Add a new plugin using the following command proxmox-datacenter-manager-admin acme plugin add dns cloudflare --api cf --data ./cf_tokens cf_tokens had the following credentials: - CF_Account_ID="" - CF_Token="" 3. Added my cloudflare managed domain under ACME Domains using the UI. 4. Ordered the certificate using the following command. proxmox-datacenter-manager-admin acme certificate order --force true 5. Force refreshed the browser and verified that the new certificate is verified by (STAGING) Let's Encrypt 6. Revoked the certificate using the following command. proxmox-datacenter-manager-admin acme certificate revoke 7. Verified the new certificate is self-signed. [1] - https://lore.proxmox.com/pbs-devel/20260116112859.194016-2-s.rufinatscha@proxmox.com/ [2] - https://github.com/letsencrypt/pebble Shan Shaji (3): cli: admin: make cli handling async fix #7179: cli: admin: expose acme commands chore: update proxmox-acme to version 1 Cargo.toml | 2 +- cli/admin/Cargo.toml | 7 +- cli/admin/src/acme.rs | 442 ++++++++++++++++++++++++++++++++++++++++++ cli/admin/src/main.rs | 54 ++++-- 4 files changed, 484 insertions(+), 21 deletions(-) create mode 100644 cli/admin/src/acme.rs -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel