From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E5CB91FF145 for ; Thu, 22 Jan 2026 10:22:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C05641139A; Thu, 22 Jan 2026 10:22:47 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Thu, 22 Jan 2026 10:19:35 +0100 Message-ID: <20260122092240.118099-2-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260122092240.118099-1-d.kral@proxmox.com> References: <20260122092240.118099-1-d.kral@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769073706453 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH ha-manager 1/1] nodestate: do not write unknown node status in get_node_state X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" PVE::HA::NodeStatus->get_node_state($node) and its proxies are accessed by many call sites with untrusted input data, e.g., migrate/relocate crm commands, node maintenance commands, etc. For example, if node 'node19' does not exist, and a user issues the migrate command, 'node19' will be written to the node state and will stay there until it is removed as a gone node (after ~60 min): $ ha-manager migrate vm:100 node19 $ ha-manager status unable to read file '/etc/pve/nodes/node19/lrm_status' quorum OK [...] lrm node19 (unable to read lrm status) [...] As the transition between unknown/gone and other node states are already handled by PVE::HA::NodeStatus->update(...), remove this side effect from get_node_state(...). Signed-off-by: Daniel Kral --- src/PVE/HA/NodeStatus.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/PVE/HA/NodeStatus.pm b/src/PVE/HA/NodeStatus.pm index e5dddf3b..381be7d0 100644 --- a/src/PVE/HA/NodeStatus.pm +++ b/src/PVE/HA/NodeStatus.pm @@ -33,10 +33,7 @@ my $valid_node_states = { sub get_node_state { my ($self, $node) = @_; - $self->{status}->{$node} = 'unknown' - if !$self->{status}->{$node}; - - return $self->{status}->{$node}; + return $self->{status}->{$node} // 'unknown'; } sub node_is_operational { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel