From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 449691FF15E for ; Wed, 21 Jan 2026 16:44:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6431E35B4; Wed, 21 Jan 2026 16:45:08 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 21 Jan 2026 16:44:35 +0100 Message-ID: <20260121154453.285642-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260121154453.285642-1-f.ebner@proxmox.com> References: <20260121154453.285642-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769010246664 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [result.data] Subject: [pve-devel] [PATCH manager v3 2/3] ui: qemu: hardware: efi: allow enrolling Microsoft+Windows UEFI CA 2023 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" When the following conditions are met: - no pending change on the EFI disk - EFI disk has pre-enrolled-keys - There is no ms-cert=2023w marker yet suggest enrolling the new Microsoft and Windows UEFI CA 2023. The previous Microsoft UEFI CA 2011 will expire in June 2026 and the previous Windows UEFI CA 2011 will expire in October 2026, so there needs to be an easy way to update. Note that this also detects drives with 'ms-cert=2023' as still needing enrollment, because they do not yet include the 'Windows UEFI CA 2023' certificate (only the 'Microsoft UEFI CA 2023' certificate). Signed-off-by: Fiona Ebner --- Changes in v3: * squash ui patches * add additional newline in confirm dialog to better separate subject from note * move enrollment to Disk Actions menu * also suggest enrollment for non-Windows guests (Linux distro shims are also signed with the Microsoft KEK) www/manager6/qemu/HardwareView.js | 89 ++++++++++++++++++++++++++++++- 1 file changed, 88 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index cf5e2a0f..aa694f76 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -442,6 +442,38 @@ Ext.define('PVE.qemu.HardwareView', { handler: run_editor, }); + let runEfiEnroll = function () { + let rec = sm.getSelection()[0]; + if (!rec) { + return; + } + + let efidisk = PVE.Parser.parsePropertyString(rec.data.value, 'file'); + efidisk['ms-cert'] = '2023w'; + + let params = {}; + params[rec.data.key] = PVE.Parser.printPropertyString(efidisk); + Proxmox.Utils.API2Request({ + url: `/api2/extjs/${baseurl}`, + waitMsgTarget: me, + method: 'POST', + params: params, + callback: () => me.reload(), + failure: (response) => Ext.Msg.alert('Error', response.htmlStatus), + success: function (response, options) { + if (response.result.data !== null) { + Ext.create('Proxmox.window.TaskProgress', { + autoShow: true, + upid: response.result.data, + listeners: { + destroy: () => me.reload(), + }, + }); + } + }, + }); + }; + let move_menuitem = new Ext.menu.Item({ text: gettext('Move Storage'), tooltip: gettext('Move disk to another storage'), @@ -510,11 +542,55 @@ Ext.define('PVE.qemu.HardwareView', { }, }); + const efiEnrollMsg = + gettext( + 'Enroll the Microsoft and Windows UEFI 2023 CA required for secure boot update.', + ) + + '
' + + gettext('This is also needed for secure boot update for common Linux distributions.') + + '
' + + '
' + + gettext('For Windows with BitLocker, run the following command inside Powershell:') + + '
manage-bde -protectors -disable <drive>
' + + Ext.String.format( + // TRANSLATORS: for a shell command: "placeholder could be 'concrete value'" + gettext("For example, {0} could be '{1}'."), + '<drive>', + 'C:', + ) + + '
' + + gettext('This is required for each drive with BitLocker before proceeding!') + + '
' + + gettext( + 'Otherwise, you will be prompted for the BitLocker recovery key on the next boot!', + ); + let efiEnrollMenuItem = new Ext.menu.Item({ + text: gettext('Enroll Updated Certificates'), + iconCls: 'fa fa-refresh', + selModel: sm, + disabled: true, + hidden: true, + handler: () => { + Ext.Msg.show({ + title: gettext('Confirm'), + icon: Ext.Msg.QUESTION, + message: efiEnrollMsg, + buttons: Ext.Msg.YESNO, + callback: function (btn) { + if (btn !== 'yes') { + return; + } + runEfiEnroll(); + }, + }); + }, + }); + let diskaction_btn = new Proxmox.button.Button({ text: gettext('Disk Action'), disabled: true, menu: { - items: [move_menuitem, reassign_menuitem, resize_menuitem], + items: [move_menuitem, reassign_menuitem, resize_menuitem, efiEnrollMenuItem], }, }); @@ -686,6 +762,17 @@ Ext.define('PVE.qemu.HardwareView', { ); remove_btn.RESTMethod = isUnusedDisk || (isDisk && isRunning) ? 'POST' : 'PUT'; + let suggestEfiEnroll = false; + if (isEfi) { + let drive = PVE.Parser.parsePropertyString(value, 'file'); + suggestEfiEnroll = + !pending && + PVE.Parser.parseBoolean(drive['pre-enrolled-keys'], false) && + drive['ms-cert'] !== '2023w'; + } + efiEnrollMenuItem.setDisabled(!suggestEfiEnroll); + efiEnrollMenuItem.setHidden(!isEfi); + edit_btn.setDisabled( deleted || !row.editor || -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel