From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 432CA1FF13E for ; Fri, 09 Jan 2026 18:37:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BAA071BF9E; Fri, 9 Jan 2026 18:37:13 +0100 (CET) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Date: Fri, 9 Jan 2026 18:35:37 +0100 Message-ID: <20260109173548.301653-3-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260109173548.301653-1-r.obkircher@proxmox.com> References: <20260109173548.301653-1-r.obkircher@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767980161234 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH v3 proxmox-backup 2/5] fix #3847: datastore: test FixedIndexWriter X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Create a dummy chunk store and write fidx files with fixed and dynamically sized writers. Compare the resulting binary files directly (ignoring uuid and ctime) and also read them back using the reader. The chunk hashes are made up and don't actually exist in the chunk store. Signed-off-by: Robert Obkircher --- pbs-datastore/src/fixed_index.rs | 184 +++++++++++++++++++++++++++++++ 1 file changed, 184 insertions(+) diff --git a/pbs-datastore/src/fixed_index.rs b/pbs-datastore/src/fixed_index.rs index 8036a519..a20edc94 100644 --- a/pbs-datastore/src/fixed_index.rs +++ b/pbs-datastore/src/fixed_index.rs @@ -530,3 +530,187 @@ impl FixedIndexWriter { Ok(()) } } + +#[cfg(test)] +mod tests { + use super::*; + use crate::chunk_store::ChunkStore; + use pbs_api_types::DatastoreFSyncLevel; + use std::fs; + use std::sync::Arc; + + const CS: usize = 4096; + + #[test] + fn test_fixed_index_writer() { + let mut testdir = fs::canonicalize(".").unwrap(); + testdir.push(".testdir_fixed_index"); + + if let Err(_e) = std::fs::remove_dir_all(&testdir) { /* ignore */ } + + // this is a lot faster than ChunkStore::create, which takes almost 3 seconds + let store = { + let mut chunks = PathBuf::from(&testdir); + chunks.push(".chunks"); + fs::create_dir_all(chunks).unwrap(); + Arc::new(ChunkStore::open("test", &testdir, DatastoreFSyncLevel::None).unwrap()) + }; + + test_empty(store.clone()); + test_smaller_than_initial_capacity(store.clone()); + test_grow_to_multiples_of_chunk_size(store.clone()); + test_grow_to_fixed_size(store); + + std::fs::remove_dir_all(&testdir).unwrap(); + } + + fn test_empty(store: Arc) { + let path = Path::new("test_empty"); + let mut w = FixedIndexWriter::create(store, path, None, CS).unwrap(); + + assert_eq!(0, w.index_length(), "returns length, not capacity"); + assert!(w.add_digest(0, &[1u8; 32]).is_err(), "out of bounds"); + assert!(w.close().is_err(), "should refuse to create empty file"); + } + + fn test_smaller_than_initial_capacity(store: Arc) { + let path = Path::new("test_smaller_than_initial_capacity"); + let mut w = FixedIndexWriter::create(store.clone(), path, None, CS).unwrap(); + + let size = CS - 1; + let expected = test_data(size); + w.grow_to_size(size).unwrap(); + expected[0].add_to(&mut w); + + w.close().unwrap(); + drop(w); + + check_with_reader(&store.relative_path(path), size, &expected); + compare_to_known_size_writer(store, path, size, &expected); + } + + fn test_grow_to_multiples_of_chunk_size(store: Arc) { + let path = Path::new("test_grow_to_multiples_of_chunk_size"); + let mut w = FixedIndexWriter::create(store.clone(), path, None, CS).unwrap(); + + let initial = FixedIndexWriter::INITIAL_CAPACITY; + let steps = [1, 2, initial, initial + 1, 5 * initial, 10 * initial + 1]; + let expected = test_data(steps.last().unwrap() * CS); + + let mut begin = 0; + for chunk_count in steps { + let last = &expected[chunk_count - 1]; + w.grow_to_size(last.end).unwrap(); + assert_eq!(last.index + 1, w.index_length()); + assert!(w.add_digest(last.index + 1, &[1u8; 32]).is_err()); + + for c in expected[begin..chunk_count].iter().rev() { + c.add_to(&mut w); + } + begin = chunk_count; + } + w.close().unwrap(); + drop(w); + + let size = expected.len() * CS; + check_with_reader(&store.relative_path(path), size, &expected); + compare_to_known_size_writer(store, path, size, &expected); + } + + fn test_grow_to_fixed_size(store: Arc) { + let path = Path::new("test_grow_to_fixed_size"); + let mut w = FixedIndexWriter::create(store.clone(), path, None, CS).unwrap(); + + let size = (FixedIndexWriter::INITIAL_CAPACITY + 42) * CS - 1; // last is not full + let expected = test_data(size); + + w.grow_to_size(size).unwrap(); + assert!(w.grow_to_size(size + 1).is_err(), "size must be fixed now"); + assert_eq!(expected.len(), w.index_length()); + assert!(w.add_digest(expected.len(), &[1u8; 32]).is_err()); + + for c in expected.iter().rev() { + c.add_to(&mut w); + } + + w.close().unwrap(); + drop(w); + + check_with_reader(&store.relative_path(path), size, &expected); + compare_to_known_size_writer(store, path, size, &expected); + } + + struct TestChunk { + digest: [u8; 32], + index: usize, + size: usize, + end: usize, + } + + impl TestChunk { + fn add_to(&self, w: &mut FixedIndexWriter) { + assert_eq!( + self.index, + w.check_chunk_alignment(self.end, self.size).unwrap() + ); + w.add_digest(self.index, &self.digest).unwrap(); + } + } + + fn test_data(size: usize) -> Vec { + (0..size.div_ceil(CS)) + .map(|index| { + let mut digest = [0u8; 32]; + let i = &(index as u64).to_le_bytes(); + for c in digest.chunks_mut(i.len()) { + c.copy_from_slice(i); + } + let size = if ((index + 1) * CS) <= size { + CS + } else { + size % CS + }; + TestChunk { + digest, + index, + size, + end: index * CS + size, + } + }) + .collect() + } + + fn check_with_reader(path: &Path, size: usize, chunks: &[TestChunk]) { + let reader = FixedIndexReader::open(path).unwrap(); + assert_eq!(size as u64, reader.index_bytes()); + assert_eq!(chunks.len(), reader.index_count()); + for c in chunks { + assert_eq!(&c.digest, reader.index_digest(c.index).unwrap()); + } + } + + fn compare_to_known_size_writer( + store: Arc, + name: &Path, + size: usize, + chunks: &[TestChunk], + ) { + let mut path = PathBuf::from(name); + path.set_extension("reference"); + let mut w = FixedIndexWriter::create(store.clone(), &path, Some(size), CS).unwrap(); + for c in chunks { + c.add_to(&mut w); + } + w.close().unwrap(); + drop(w); + + let mut reference = fs::read(store.relative_path(&path)).unwrap(); + let mut tested = fs::read(store.relative_path(name)).unwrap(); + + // ignore uuid and ctime + reference[8..32].fill(0); + tested[8..32].fill(0); + + assert_eq!(reference, tested); + } +} -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel