From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 441CD1FF13D for ; Thu, 08 Jan 2026 16:25:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6FE1E27E23; Thu, 8 Jan 2026 16:25:41 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 8 Jan 2026 16:25:18 +0100 Message-ID: <20260108152520.783200-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108152520.783200-1-c.ebner@proxmox.com> References: <20260108152520.783200-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767885900064 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 2/4] tree-wide: fix clippy warnings needless borrow X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Omit all needless borrows currently reported by clippy run. No functional changes. Signed-off-by: Christian Ebner --- pbs-datastore/src/chunk_store.rs | 2 +- pbs-datastore/src/datastore.rs | 4 ++-- src/api2/admin/datastore.rs | 4 ++-- src/auth.rs | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs index cccfcfcdf..315e18218 100644 --- a/pbs-datastore/src/chunk_store.rs +++ b/pbs-datastore/src/chunk_store.rs @@ -758,7 +758,7 @@ impl ChunkStore { let gid = pbs_config::backup_group()?.gid; create_options = create_options.owner(uid).group(gid); } - proxmox_sys::fs::replace_file(&path, &[], create_options, false) + proxmox_sys::fs::replace_file(path, &[], create_options, false) } /// Mark chunk as expected to be present by writing a file the chunk store. diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index 2f401f6fd..83d209414 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -2007,7 +2007,7 @@ impl DataStore { ) -> Result<(bool, u64), Error> { match backend { DatastoreBackend::Filesystem => self.inner.chunk_store.insert_chunk(chunk, digest), - DatastoreBackend::S3(s3_client) => self.insert_chunk_cached(chunk, digest, &s3_client), + DatastoreBackend::S3(s3_client) => self.insert_chunk_cached(chunk, digest, s3_client), } } @@ -2062,7 +2062,7 @@ impl DataStore { // or the chunk marker file exists on filesystem. The latter means the chunk has // been uploaded in the past, but was evicted from the LRU cache since but was not // cleaned up by garbage collection, so contained in the S3 object store. - if self.cache_contains(&digest) { + if self.cache_contains(digest) { tracing::info!("Skip upload of cached chunk {}", hex::encode(digest)); return Ok((true, chunk_size)); } diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs index ddd894c12..88ad5d53b 100644 --- a/src/api2/admin/datastore.rs +++ b/src/api2/admin/datastore.rs @@ -2734,8 +2734,8 @@ pub fn s3_refresh(store: String, rpcenv: &mut dyn RpcEnvironment) -> Result Result<(), Error> { - let datastore = DataStore::lookup_datastore(&store, Some(Operation::Lookup))?; - run_maintenance_locked(&store, MaintenanceType::S3Refresh, worker, || { + let datastore = DataStore::lookup_datastore(store, Some(Operation::Lookup))?; + run_maintenance_locked(store, MaintenanceType::S3Refresh, worker, || { proxmox_async::runtime::block_on(datastore.s3_refresh()) }) } diff --git a/src/auth.rs b/src/auth.rs index a930d8cd9..24bb3f753 100644 --- a/src/auth.rs +++ b/src/auth.rs @@ -475,7 +475,7 @@ impl proxmox_auth_api::api::AuthContext for PbsAuthContext { path_vec.push(part); } } - user_info.check_privs(&auth_id, &path_vec, *privilege, false)?; + user_info.check_privs(auth_id, &path_vec, *privilege, false)?; return Ok(Some(true)); } } -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel