From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A83171FF15E for ; Mon, 5 Jan 2026 15:06:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 380E79579; Mon, 5 Jan 2026 15:07:33 +0100 (CET) From: Kefu Chai To: pve-devel@lists.proxmox.com Date: Mon, 5 Jan 2026 22:05:52 +0800 Message-ID: <20260105140709.1214107-1-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767622006275 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-fuse-rs] Remove deprecated shared_flag() call from build script X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Wolfgang Bumiller Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Root cause: The cc crate deprecated the shared_flag() method because it only creates static libraries (.a files), making the shared_flag parameter meaningless and confusing. The warning indicated: warning: use of deprecated method `cc::Build::shared_flag`: cc only creates static libraries, setting this does nothing Impact: - shared_flag(false) was a no-op that did nothing - Its removal does not change the build behavior - The build still produces libglue.a as expected Fix: Remove the .shared_flag(false) call from the cc::Build chain. The build defaults to static library output, which is what we want. Verification: - Build completes without warnings - Generated library is still static (.a) - No functional changes to the FUSE bindings Signed-off-by: Kefu Chai --- build.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/build.rs b/build.rs index d75166e..f9dd5f1 100644 --- a/build.rs +++ b/build.rs @@ -11,10 +11,7 @@ fn main() { let mut cc = cc::Build::new(); - cc.pic(true) - .shared_flag(false) - .opt_level(3) - .flag("-DFUSE_USE_VERSION=35"); + cc.pic(true).opt_level(3).flag("-DFUSE_USE_VERSION=35"); for flag in ccflags.split_ascii_whitespace() { cc.flag(flag); -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel