From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EF2A71FF187 for ; Fri, 2 Jan 2026 15:35:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DEFD2D078; Fri, 2 Jan 2026 15:36:20 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Fri, 2 Jan 2026 15:35:41 +0100 Message-ID: <20260102143544.354066-7-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260102143544.354066-1-m.sandoval@proxmox.com> References: <20260102143544.354066-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767364514553 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.090 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v4 6/8] block job: log when a fsfreeze could not happen X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" We print a message when the config says that we should issue a guest-fsfreeze-freeze command but we can't because the agent is not running or vise versa. Signed-off-by: Maximiliano Sandoval --- src/PVE/QemuServer/BlockJob.pm | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm index b25dcf9a..313918e3 100644 --- a/src/PVE/QemuServer/BlockJob.pm +++ b/src/PVE/QemuServer/BlockJob.pm @@ -162,11 +162,17 @@ sub qemu_drive_mirror_monitor { last if $completion eq 'skip' || $completion eq 'auto'; if ($vmiddst && $vmiddst != $vmid) { - my $agent_running = $qga && qga_check_running($vmid); - if ($agent_running) { + my $agent_running = qga_check_running($vmid); + my $should_fsfreeze = $qga && $agent_running; + if ($should_fsfreeze) { print "freeze filesystem\n"; eval { PVE::QemuServer::Agent::guest_fsfreeze($vmid); }; warn $@ if $@; + } elsif ($agent_running && !$qga) { + print "skipping guest-agent 'guest-fsfreeze-freeze', disabled in VM options\n"; + } elsif (!$agent_running && $qga) { + print + "skipping guest agent 'guest-fsfreeze-freeze' command: the agent is not running inside of the guest\n"; } else { print "suspend vm\n"; eval { PVE::QemuServer::RunState::vm_suspend($vmid, 1); }; @@ -176,7 +182,7 @@ sub qemu_drive_mirror_monitor { # if we clone a disk for a new target vm, we don't switch the disk qemu_blockjobs_cancel($vmid, $jobs); - if ($agent_running) { + if ($should_fsfreeze) { print "unfreeze filesystem\n"; eval { PVE::QemuServer::Agent::guest_fsthaw($vmid); }; warn $@ if $@; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel