From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2CD4C1FF187 for ; Fri, 2 Jan 2026 15:35:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0558ECF4A; Fri, 2 Jan 2026 15:36:19 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Fri, 2 Jan 2026 15:35:35 +0100 Message-ID: <20260102143544.354066-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767364514132 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH guest-common/qemu-server v4 0/9] fix #1964: add setting to always disable freezing a guest's fs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" ..and add more logging when issuing fsfreeze guest commands. The new setting takes precedence over freeze-fs-on-backup and deprecates the former. - At the moment taking a snapshot without RAM does not log whether there was a freeze/thaw, we add logs when issuing freezes/thaws. - The patch does not result in an extra log line when making a Backup in snapshot mode. - When it is easy to do so, we log if the fsfreeze command was not issued due to mismatch between the agent running and the config, e.g. when say that we skipped it if the agent is enabled bu the configuration says we shouldn't. What was tested: - Backups of a VM with and another without guest-fsfreeze enabled. They both print a message indicating that a fsfreeze happend. - A live clone of a VM with and another without guest-fsfreeze enabled. They both print a message indicating that a fsfreeze happend. - Snapshot of a VM with and another without guest-fsfreeze enabled. Only the format logged a message indicating that a fsfreeze happened. Differences from v3: - Instead of removing logfunc statements and adding a print to the base __snapshot_freeze we add a print on the snapshot method which was the one missing a log. This means we do not need changes in pve-container anymore. - Add a helper to thaw a qemu guest. This is done only for readability. - Read the guest config right at the start of the worker - Rebase on top of master Differences from v2: - Print a message on live clones when fsfreeze is skipped due to config - Clean up code a bit - rebase - Fix a typo Differences from v1: - Add setting to enable/disable fsfreeze commands - Change wording in one log message qemu-server: Maximiliano Sandoval (8): add a guest-fsfreeze qga setting api: clone_vm: follow guest-fsfreeze setting fix #1964: follow guest-fsfreeze setting on check freeze needed agent: add a guest_fsthaw helper port users of guest-fsfreeze-thaw users to helper block job: log when a fsfreeze could not happen block job: mirror: reword fsfreeze log entry deprecate freeze-fs-on-backup qga setting src/PVE/API2/Qemu.pm | 5 ++++- src/PVE/QemuConfig.pm | 5 +++-- src/PVE/QemuServer/Agent.pm | 31 ++++++++++++++++++++++++++++++- src/PVE/QemuServer/BlockJob.pm | 18 ++++++++++++------ src/PVE/VZDump/QemuServer.pm | 9 ++++++--- 5 files changed, 55 insertions(+), 13 deletions(-) pve-guest-common: Maximiliano Sandoval (1): abstract config: print when {,un}freezing a fs src/PVE/AbstractConfig.pm | 2 ++ 1 file changed, 2 insertions(+) Summary over all repositories: 6 files changed, 57 insertions(+), 13 deletions(-) -- Generated by murpp 0.9.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel