From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D1EEB1FF17C for ; Tue, 30 Dec 2025 13:55:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CB963B46A; Tue, 30 Dec 2025 13:56:09 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Tue, 30 Dec 2025 13:55:10 +0100 Message-ID: <20251230125535.130173-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767099308768 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.091 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH container] setup: centos: separate dns-search list with semicolons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This is a followup of 6e08c550. Unlike the previous commit, the key `dns-search` is not documented as part of the manual page `nm-settings-keyfile(5)`. Here we rely solely on lists being generally semicolon-separated in NetworkManager and the test case `Test_Wireless_Connection` [1, 2, 3]. [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/src/core/settings/plugins/keyfile/tests/test-keyfile-settings.c?ref_type=820e56c5df80d6f5a4019c82f0f60b3303ecfa17#L281 [2] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/src/core/settings/plugins/keyfile/tests/test-keyfile-settings.c?ref_type=820e56c5df80d6f5a4019c82f0f60b3303ecfa17#L370-L372 [3] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/src/core/settings/plugins/keyfile/tests/keyfiles/Test_Wired_Connection#L52 Signed-off-by: Maximiliano Sandoval --- src/PVE/LXC/Setup/CentOS.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm index 7bccca2..2469046 100644 --- a/src/PVE/LXC/Setup/CentOS.pm +++ b/src/PVE/LXC/Setup/CentOS.pm @@ -245,7 +245,7 @@ sub setup_network_with_networkmanager { } if (@name_servers_v4) { $data .= "dns=" . join(';', @name_servers_v4) . "\n"; - $data .= "dns-search=" . join(' ', PVE::Tools::split_list($searchdomains)) . "\n" + $data .= "dns-search=" . join(';', PVE::Tools::split_list($searchdomains)) . "\n" if $searchdomains; } } else { @@ -271,7 +271,7 @@ sub setup_network_with_networkmanager { } if (@name_servers_v6) { $data .= "dns=" . join(';', @name_servers_v6) . "\n"; - $data .= "dns-search=" . join(' ', PVE::Tools::split_list($searchdomains)) . "\n" + $data .= "dns-search=" . join(';', PVE::Tools::split_list($searchdomains)) . "\n" if $searchdomains; } } else { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel