From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E07931FF17C for ; Tue, 16 Dec 2025 14:02:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7EB40F174; Tue, 16 Dec 2025 14:03:09 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 16 Dec 2025 14:02:21 +0100 Message-ID: <20251216130230.104772-11-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251216130230.104772-1-f.ebner@proxmox.com> References: <20251216130230.104772-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765890146033 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH storage 10/11] plugin: volume snapshot info: do not set 'ext' property X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The 'snapshot-as-volume-chain' storage configuration option determines whether handling for external snapshots is done or not. The 'ext' marker returned by volume_snapshot_info() doesn't add any information. Also, the LVM plugin didn't return the 'ext' marker, making it inconsistent. Remove the marker. Signed-off-by: Fiona Ebner --- src/PVE/Storage/Plugin.pm | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 6fb4b98..d60e023 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1154,7 +1154,6 @@ sub free_image { ) { my $snap = $snapshots->{$snapid}; next if $snapid eq 'current'; - next if !$snap->{ext}; eval { free_snap_image($class, $storeid, $scfg, $volname, $snapid); }; warn $@ if $@; } @@ -1865,9 +1864,6 @@ Required values are: =item C: Number that determines the position in the backing chain. C<0> for the current image, one more for each step further back in the volume chain. -=item C: May be set if the snapshot is external when internal snapshots are also supported by -the storage. - =back For replication support, returns an empty hash if the volume does not exist. Required values are: @@ -1930,7 +1926,6 @@ sub volume_snapshot_info { $info->{$snapname}->{volname} = "$snapvolname"; $info->{$snapname}->{volid} = "$storeid:$snapvolname"; $info->{$snapname}->{'virtual-size'} = $snap->{'virtual-size'}; - $info->{$snapname}->{ext} = 1; my $parentfile = $snap->{'backing-filename'}; if ($parentfile) { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel