From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 294001FF178 for ; Mon, 15 Dec 2025 14:27:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 52D12BF75; Mon, 15 Dec 2025 14:27:47 +0100 (CET) From: Lukas Wagner To: pbs-devel@lists.proxmox.com Date: Mon, 15 Dec 2025 14:27:33 +0100 Message-ID: <20251215132733.216592-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765805255877 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] api: notification: correctly enumerate known push-sync-jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" The second parameter of list_config_sync_jobs determines the direction (either push, pull, or both) of jobs that should be returned. Using a value of 'None' makes the implementation fall back to the default, which is 'pull'. This led to only pull-style jobs being returned from the 'matcher-field-values' endpoint. This issue likely existed since the introduction of push-style jobs. Fixes: https://forum.proxmox.com/threads/170987 Signed-off-by: Lukas Wagner --- src/api2/config/notifications/mod.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/api2/config/notifications/mod.rs b/src/api2/config/notifications/mod.rs index f79fc78b7..40fe4dfaa 100644 --- a/src/api2/config/notifications/mod.rs +++ b/src/api2/config/notifications/mod.rs @@ -12,7 +12,7 @@ use crate::api2::admin::datastore::get_datastore_list; use pbs_api_types::PRIV_SYS_AUDIT; use crate::api2::admin::prune::list_prune_jobs; -use crate::api2::admin::sync::list_config_sync_jobs; +use crate::api2::admin::sync::{list_config_sync_jobs, ListSyncDirection}; use crate::api2::admin::verify::list_verification_jobs; use crate::api2::config::media_pool::list_pools; use crate::api2::tape::backup::list_tape_backup_jobs; @@ -156,7 +156,8 @@ pub fn get_values( }); } - let sync_jobs = list_config_sync_jobs(None, None, param.clone(), rpcenv)?; + let sync_jobs = + list_config_sync_jobs(None, Some(ListSyncDirection::All), param.clone(), rpcenv)?; for job in sync_jobs { values.push(MatchableValue { field: "job-id".into(), -- 2.47.3 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel