From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8AAEE1FF178 for ; Mon, 15 Dec 2025 11:23:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 531497208; Mon, 15 Dec 2025 11:24:17 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Mon, 15 Dec 2025 11:18:37 +0100 Message-ID: <20251215102409.142350-5-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251215102409.142350-1-d.kral@proxmox.com> References: <20251215102409.142350-1-d.kral@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765794246301 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH ha-manager 4/4] manager: group migration: bulk update changes to resource config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The migration process from HA groups to HA rules might require a lot of small updates to individual HA resource configs. These updates have been done per-HA resource, which is quite inefficient and can cause the CRM to fail to update its watchdog in time. Even though this is a one-off procedure, it is part of the HA Manager state machine and must be done in a single action to prevent reading from an partially updated resource config, i.e., no forking or splitting the task over multiple HA Manager rounds. Therefore use the bulk capability of update_resources_config(...) to remove the group fields and migrate the failback flag for all HA resources in a single read-update-write operation. Signed-off-by: Daniel Kral --- src/PVE/HA/Manager.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index f55d5870..bf368efd 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -579,16 +579,15 @@ my $migrate_group_persistently = sub { $haenv->log('notice', "ha groups migration: migration to rules config successful"); PVE::HA::Groups::migrate_groups_to_resources($groups, $resources); + my $changes = {}; for my $sid (keys %$resources) { # prevent unnecessary updates for HA resources that do not change next if !defined($resources->{$sid}->{group}); - my $changes = {}; $changes->{$sid} = {}; $changes->{$sid}->{failback} = 0 if !$resources->{$sid}->{failback}; - - $haenv->update_service_config($changes, 'group'); } + $haenv->update_service_config($changes, 'group'); $haenv->log('notice', "ha groups migration: migration to resources config successful"); $haenv->delete_group_config(); -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel