From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7683C1FF179 for ; Wed, 10 Dec 2025 14:28:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5BCFA1C8A9; Wed, 10 Dec 2025 14:29:11 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 10 Dec 2025 14:28:12 +0100 Message-ID: <20251210132833.135013-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251210125724.121834-1-f.ebner@proxmox.com> References: <20251210125724.121834-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765373310062 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemumigrate.pm] Subject: [pve-devel] [PATCH v3 qemu-server 3/3] migrate: remove left-over dbus-vmstate instance when migrating without conntrack state X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" As reported in the enterprise support, if something went wrong when removing the dbus-vmstate object earlier, a following migrating using '--with-conntrack-state' will lead to a crash. Try to remove any leftover when migrating without the conntrack state. Signed-off-by: Fiona Ebner --- Reported by Friedrich just after I sent the v3. Technically orthogonal, and should get much less likely after patches 1+2 here, but still good for future-proofing. src/PVE/QemuMigrate.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm index 8fa84080..b3ddc34e 100644 --- a/src/PVE/QemuMigrate.pm +++ b/src/PVE/QemuMigrate.pm @@ -254,6 +254,12 @@ sub prepare { 'conntrack state migration not supported or disabled, ' . 'active connections might get dropped', ); + + # In case some leftover instance is running, stop it. The target QEMU instance won't + # have the 'dbus-vmstate' object, so the source must not have it either. + if (defined(PVE::QemuServer::DBusVMState::qemu_del_dbus_vmstate($vmid, quiet => 1))) { + $self->log('warn', "stopped left-over dbus-vmstate helper for VM $vmid"); + } } } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel