From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 71ABB1FF179 for ; Wed, 10 Dec 2025 13:56:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 83A871C0F0; Wed, 10 Dec 2025 13:57:30 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 10 Dec 2025 13:57:07 +0100 Message-ID: <20251210125724.121834-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251210125724.121834-1-f.ebner@proxmox.com> References: <20251210125724.121834-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765371440631 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [dbusvmstate.pm] Subject: [pve-devel] [PATCH v3 qemu-server 1/2] dbus-vmstate: introduce dbus_call_method() helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Similar to the already existing dbus_get_property() helper, the owner is respected even if there are multiple (queued) owners on the DBus. Have the dbus_get_property() helper use the new function to avoid duplication. In preparation to fix the call to 'Quit'. Signed-off-by: Fiona Ebner --- Changes in v3: * split patch * replace dbus_get_property() with a wrapper around dbus_call_method() src/PVE/QemuServer/DBusVMState.pm | 39 ++++++++++++++++++++----------- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/src/PVE/QemuServer/DBusVMState.pm b/src/PVE/QemuServer/DBusVMState.pm index a72d6dd2..05dd1bcd 100644 --- a/src/PVE/QemuServer/DBusVMState.pm +++ b/src/PVE/QemuServer/DBusVMState.pm @@ -16,6 +16,30 @@ use constant { DBUS_VMSTATE_EXE => '/usr/libexec/qemu-server/dbus-vmstate', }; +# Call a method for an object from a specific interface name. +# In contrast to calling the method directly by using $obj->Method(), this +# actually respects the owner of the object and thus can be used for interfaces +# with might have multiple (queued) owners on the DBus. +my sub dbus_call_method { + my ($obj, $interface, $method, $params, $timeout) = @_; + + $timeout = 10 if !$timeout; + + my $con = $obj->{service}->get_bus()->get_connection(); + + my $call = $con->make_method_call_message( + $obj->{service}->get_service_name(), + $obj->{object_path}, + $interface, + $method, + ); + + $call->set_destination($obj->get_service()->get_owner_name()); + $call->append_args_list($params->@*) if $params; + + return $con->send_with_reply_and_block($call, $timeout * 1000)->get_args_list(); +} + # Retrieves a property from an object from a specific interface name. # In contrast to accessing the property directly by using $obj->Property, this # actually respects the owner of the object and thus can be used for interfaces @@ -23,19 +47,8 @@ use constant { my sub dbus_get_property { my ($obj, $interface, $name) = @_; - my $con = $obj->{service}->get_bus()->get_connection(); - - my $call = $con->make_method_call_message( - $obj->{service}->get_service_name(), - $obj->{object_path}, - 'org.freedesktop.DBus.Properties', - 'Get', - ); - - $call->set_destination($obj->get_service()->get_owner_name()); - $call->append_args_list($interface, $name); - - my @reply = $con->send_with_reply_and_block($call, 10 * 1000)->get_args_list(); + my @reply = + dbus_call_method($obj, 'org.freedesktop.DBus.Properties', 'Get', [$interface, $name]); return $reply[0]; } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel