From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1759B1FF183 for ; Wed, 3 Dec 2025 14:40:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4DABBAA44; Wed, 3 Dec 2025 14:40:53 +0100 (CET) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Date: Wed, 3 Dec 2025 14:40:41 +0100 Message-ID: <20251203134050.3215934-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager] ui: default dashboard: don't load/show the subscription notice X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" we already have the subscription panel there, so showing it again does not make much sense. Keep it in the custom views, as there the subscription panel is limited to the specific view. To detect if we're in a custom view, use the 'editing_state' property, which is only set when we can edit the view, and that is not the case for the default dashboard. Signed-off-by: Dominik Csapak --- ui/src/dashboard/status_row.rs | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/ui/src/dashboard/status_row.rs b/ui/src/dashboard/status_row.rs index 582a9b87..b34ac9f7 100644 --- a/ui/src/dashboard/status_row.rs +++ b/ui/src/dashboard/status_row.rs @@ -87,6 +87,10 @@ impl PdmDashboardStatusRow { } fn load_subscription(&self, ctx: &yew::Context) { + // only load the subscription info here in custom views + if ctx.props().editing_state.is_none() { + return; + } self.async_pool.send_future(ctx.link().clone(), async move { let res = proxmox_yew_comp::http_get("/nodes/localhost/subscription", None).await; Msg::SubscriptionInfoLoaded(res) @@ -144,8 +148,10 @@ impl Component for PdmDashboardStatusRow { fn view(&self, ctx: &yew::Context) -> yew::Html { let props = ctx.props(); - let is_loading = - props.last_refresh.is_none() || self.loading || !self.subscription_info.has_data(); + let is_custom_view = props.editing_state.is_some(); + let is_loading = props.last_refresh.is_none() + || self.loading + || (is_custom_view && !self.subscription_info.has_data()); let on_settings_click = props.on_settings_click.clone(); Row::new() .gap(1) @@ -170,8 +176,8 @@ impl Component for PdmDashboardStatusRow { } None => tr!("Now refreshing"), })) - .with_optional_child(create_subscription_notice(&self.subscription_info).map( - |element| { + .with_optional_child(if is_custom_view { + create_subscription_notice(&self.subscription_info).map(|element| { element.class("pwt-pointer").onclick({ let link = ctx.link().clone(); move |_| { @@ -180,8 +186,10 @@ impl Component for PdmDashboardStatusRow { } } }) - }, - )) + }) + } else { + None + }) .with_flex_spacer() .with_optional_child(props.editing_state.clone().and_then(|_| { (!self.edit).then_some({ -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel