From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 908861FF15C for ; Fri, 28 Nov 2025 16:38:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 105E11E1FF; Fri, 28 Nov 2025 16:39:00 +0100 (CET) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Date: Fri, 28 Nov 2025 16:38:54 +0100 Message-ID: <20251128153855.543210-4-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251128153855.543210-1-s.sterz@proxmox.com> References: <20251128153855.543210-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764344297122 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.215 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy ENA_SUBJ_ODD_CASE 2.6 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager 3/4] api: pve: make to `get_storage_rrd_data` return PveStorageDataPoint X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" this worked so far by accident as `NodeDataPoint` has the field that are also specified in `PveStorageDataPoint`, but marks all additional fields as optional. fix this by using the proper return type. pdm-client already uses the correct return type anyway. Signed-off-by: Shannon Sterz --- server/src/api/pve/rrddata.rs | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/server/src/api/pve/rrddata.rs b/server/src/api/pve/rrddata.rs index 226b675..08db107 100644 --- a/server/src/api/pve/rrddata.rs +++ b/server/src/api/pve/rrddata.rs @@ -289,8 +289,15 @@ async fn get_node_rrd_data( access: { permission: &Permission::Privilege(&["resource", "{remote}", "storage", "{storage}"], PRIV_RESOURCE_AUDIT, false), }, + returns: { + type: Array, + description:"A list of RRD data points on a PVE remote's storage.", + items: { + type: PveStorageDataPoint, + } + } )] -/// Read node stats +/// Read storage stats async fn get_storage_rrd_data( remote: String, node: String, @@ -298,7 +305,7 @@ async fn get_storage_rrd_data( timeframe: RrdTimeframe, cf: RrdMode, _param: Value, -) -> Result, Error> { +) -> Result, Error> { let base = format!("pve/{remote}/storage/{node}/{storage}"); rrd_common::get_rrd_datapoints(remote, base, timeframe, cf).await } -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel