From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4B7A21FF15C for ; Fri, 28 Nov 2025 13:52:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5F76B1A771; Fri, 28 Nov 2025 13:53:14 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 28 Nov 2025 13:52:09 +0100 Message-ID: <20251128125237.117539-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764334321394 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server] qm cleanup: avoid problematic cleanup during rollback X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" During preparation for rollback, there already is a VM cleanup. The rollback operation temporarily drops the file lock for the configuration while doing rollback of the volumes on the storage layer. If a shutdown operation or more precisely, the cleanup thereafter happens concurrently, it can get the file lock and do the cleanup (a second time) while rollback is running. If a badly timed deactivate for the volume happens, this can cause issues as reported in the community forum [0] and confirmed locally (but only managed to reproduce with 'saferemove'). [0]: https://forum.proxmox.com/threads/174875/post-815273 Signed-off-by: Fiona Ebner --- src/PVE/CLI/qm.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm index bfce860f..60fe318e 100755 --- a/src/PVE/CLI/qm.pm +++ b/src/PVE/CLI/qm.pm @@ -1111,6 +1111,12 @@ __PACKAGE__->register_method({ my $pid = PVE::QemuServer::check_running($vmid); die "vm still running\n" if $pid; + # Rollback already does cleanup when preparing and afterwards temporarily drops the + # lock on the configuration file to rollback the volumes. Deactivating volumes here + # again while that is happening would be problematic. + die "skipping cleanup - 'rollback' lock is present\n" + if $conf->{lock} && $conf->{lock} eq 'rollback'; + if (!$clean) { # we have to cleanup the tap devices after a crash -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel