From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4C1951FF15C for ; Fri, 28 Nov 2025 11:47:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B966917702; Fri, 28 Nov 2025 11:48:02 +0100 (CET) From: Dominik Csapak To: pdm-devel@lists.proxmox.com Date: Fri, 28 Nov 2025 11:47:55 +0100 Message-ID: <20251128104800.1811360-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager] ui: pve: node: cleanup X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" the changed method will only be called if the properties change and return true if none is given. So returning true when any property changed is already the default behavior, no need for us to implement it again. Signed-off-by: Dominik Csapak --- ui/src/pve/node/mod.rs | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/ui/src/pve/node/mod.rs b/ui/src/pve/node/mod.rs index 66ce8dda..1fcd92eb 100644 --- a/ui/src/pve/node/mod.rs +++ b/ui/src/pve/node/mod.rs @@ -2,10 +2,7 @@ use std::rc::Rc; use gloo_utils::window; use proxmox_yew_comp::{AptPackageManager, ConsoleType, XTermJs}; -use yew::{ - virtual_dom::{VComp, VNode}, - Context, -}; +use yew::virtual_dom::{VComp, VNode}; use pwt::{ css::{AlignItems, ColorScheme}, @@ -51,12 +48,6 @@ impl yew::Component for PveNodePanelComp { Self } - fn changed(&mut self, ctx: &Context, old_props: &Self::Properties) -> bool { - let props = ctx.props(); - - props.remote != old_props.remote || props.node != old_props.node - } - fn view(&self, ctx: &yew::Context) -> yew::Html { let props = ctx.props(); -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel