From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 473AF1FF17E for ; Thu, 27 Nov 2025 16:36:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 086007D95; Thu, 27 Nov 2025 16:36:52 +0100 (CET) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Date: Thu, 27 Nov 2025 16:36:08 +0100 Message-ID: <20251127153609.440415-7-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251127153609.440415-1-s.sterz@proxmox.com> References: <20251127153609.440415-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764257737357 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH datacenter-manager 5/6] ui: node status: handle the request via an AsyncAbortGuard X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" this makes it possible to abort a request when another one is triggered here. in theory this could also trigger a race condition with a potential login. however, as a user would need to trigger it manually, this is rather unlikely to happen in practice. Signed-off-by: Shannon Sterz --- ui/src/administration/node_status.rs | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/ui/src/administration/node_status.rs b/ui/src/administration/node_status.rs index cce3426..a3338bb 100644 --- a/ui/src/administration/node_status.rs +++ b/ui/src/administration/node_status.rs @@ -7,6 +7,7 @@ use proxmox_node_status::NodePowerCommand; use proxmox_yew_comp::{http_post, ConfirmButton, NodeStatusPanel}; use pwt::prelude::*; use pwt::widget::{Column, Container, Row}; +use pwt::AsyncAbortGuard; #[derive(Properties, Clone, PartialEq)] pub(crate) struct NodeStatus {} @@ -31,18 +32,22 @@ enum Msg { struct PdmNodeStatus { error: Option, + abort_guard: Option, } impl PdmNodeStatus { - fn change_power_state(&self, ctx: &yew::Context, command: NodePowerCommand) { - ctx.link().send_future(async move { + fn change_power_state(&mut self, ctx: &yew::Context, command: NodePowerCommand) { + let link = ctx.link().clone(); + self.abort_guard.replace(AsyncAbortGuard::spawn(async move { let data = Some(serde_json::json!({"command": command})); - match http_post("/nodes/localhost/status", data).await { + let res = match http_post("/nodes/localhost/status", data).await { Ok(()) => Msg::Reload, Err(e) => Msg::Error(e), - } - }); + }; + + link.send_message(res); + })); } } @@ -51,7 +56,10 @@ impl Component for PdmNodeStatus { type Properties = NodeStatus; fn create(_ctx: &yew::Context) -> Self { - Self { error: None } + Self { + error: None, + abort_guard: None, + } } fn update(&mut self, ctx: &yew::Context, msg: Self::Message) -> bool { -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel