From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E86601FF17E for ; Thu, 27 Nov 2025 12:34:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5624916C7; Thu, 27 Nov 2025 12:34:33 +0100 (CET) From: Dietmar Maurer To: pdm-devel@lists.proxmox.com Date: Thu, 27 Nov 2025 12:34:24 +0100 Message-ID: <20251127113428.911697-1-dietmar@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.582 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pdm-devel] [PATCH datacenter-manager 1/5] server: api: qemu: add pending api X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Signed-off-by: Dietmar Maurer --- server/src/api/pve/qemu.rs | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/server/src/api/pve/qemu.rs b/server/src/api/pve/qemu.rs index 4f144b7..effa7e5 100644 --- a/server/src/api/pve/qemu.rs +++ b/server/src/api/pve/qemu.rs @@ -14,7 +14,7 @@ use pdm_api_types::{ PRIV_RESOURCE_MANAGE, PRIV_RESOURCE_MIGRATE, SNAPSHOT_NAME_SCHEMA, VMID_SCHEMA, }; -use pve_api_types::{QemuMigratePreconditions, StartQemuMigrationType}; +use pve_api_types::{PendingConfigValue, QemuMigratePreconditions, StartQemuMigrationType}; use crate::api::pve::get_remote; @@ -33,6 +33,7 @@ const QEMU_VM_ROUTER: Router = Router::new() #[sortable] const QEMU_VM_SUBDIRS: SubdirMap = &sorted!([ ("config", &Router::new().get(&API_METHOD_QEMU_GET_CONFIG)), + ("pending", &Router::new().get(&API_METHOD_QEMU_GET_PENDING)), ("rrddata", &super::rrddata::QEMU_RRD_ROUTER), ("start", &Router::new().post(&API_METHOD_QEMU_START)), ("status", &Router::new().get(&API_METHOD_QEMU_GET_STATUS)), @@ -152,6 +153,39 @@ pub async fn qemu_get_config( .await?) } +#[api( + input: { + properties: { + remote: { schema: REMOTE_ID_SCHEMA }, + node: { + schema: NODE_SCHEMA, + optional: true, + }, + vmid: { schema: VMID_SCHEMA }, + }, + }, + // Note: the trait `ApiType` is not implemented for `PendingConfigValue` because it contains Value + // returns: { description: "Configuration property with pending changes.", type: Array, items: { type: PendingConfigValue, }}, + access: { + permission: &Permission::Privilege(&["resource", "{remote}", "guest", "{vmid}"], PRIV_RESOURCE_AUDIT, false), + }, +)] +/// Get the pending configuration of a qemu VM from a remote. If a node is provided, the VM must be on that +/// node, otherwise the node is determined automatically. +pub async fn qemu_get_pending( + remote: String, + node: Option, + vmid: u32, +) -> Result, Error> { + let (remotes, _) = pdm_config::remotes::config()?; + + let pve = connect_to_remote(&remotes, &remote)?; + + let node = find_node_for_vm(node, vmid, pve.as_ref()).await?; + + Ok(pve.qemu_get_pending(&node, vmid).await?) +} + #[api( input: { properties: { -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel