From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E665D1FF15E for ; Mon, 24 Nov 2025 12:04:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AA7D51FB69; Mon, 24 Nov 2025 12:05:00 +0100 (CET) From: Nicolas Frey To: pbs-devel@lists.proxmox.com Date: Mon, 24 Nov 2025 12:04:20 +0100 Message-ID: <20251124110427.194887-1-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.103 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH proxmox{, -backup} v2 0/7] tuning: verify: add verify job thread options X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" this patch series aims to expose configuration of the number of threads to use for reading and verifying of verify jobs through the datastore's tuning options. It expands on the series I sent last week [0], where @Thomas suggested making this configurable through the tuning options too. @Chris suggested adding a dedicated worker thread settings to the datastore instead, which is an approach I don't have a problem with, but I'd want some more opinions on. If the docs should be updated to account for this change, I can either send a follow up or do that in a v2. Later down the line, it would also be beneficial to add the tape job threads to these options, though that is outside of the scope of this series. [0] https://lore.proxmox.com/pbs-devel/5a731352-1f77-4b15-9a22-7064b70ce519@proxmox.com/T/#t Changes since v1 (thanks Chris!): * renamed user-facing parameters to make them less clumsy and clearer * add the new tuning parameters to the docs * adapt `render_tuning_options` * cleaned up nits proxmox: Nicolas Frey (1): pbs-api-types: add default-verification-{workers,readers} to tuning options pbs-api-types/src/datastore.rs | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) proxmox-backup: Nicolas Frey (6): datastore: add new thread settings to tuning options verify: use tuning options' thread settings for {verify,read}-threads ui: tuning: make default-verification-{workers,readers} configurable ui: tuning: render verification threads in tuning options ui: verify: fetch default {read,verify} thread values from tuning options docs: tuning: document default-verification-{workers,readers} docs/storage.rst | 5 +++++ pbs-datastore/src/datastore.rs | 34 ++++++++++++++++++++++++++++++ src/backup/verify.rs | 14 +++++++++++-- www/Utils.js | 12 +++++++++++ www/datastore/OptionView.js | 20 ++++++++++++++++++ www/window/VerifyAll.js | 38 ++++++++++++++++++++++++++++++++-- www/window/VerifyJobEdit.js | 37 +++++++++++++++++++++++++++++++++ 7 files changed, 156 insertions(+), 4 deletions(-) Summary over all repositories: 8 files changed, 170 insertions(+), 5 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel