From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8D7FB1FF15E for ; Mon, 24 Nov 2025 11:35:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0FAB41EFE0; Mon, 24 Nov 2025 11:35:37 +0100 (CET) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Date: Mon, 24 Nov 2025 11:34:42 +0100 Message-ID: <20251124103444.117406-3-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251124103444.117406-2-s.sterz@proxmox.com> References: <20251124103444.117406-2-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763980468550 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox v2 1/1] upgrade-checks: fix meta package version check X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" old_version is an optional value, so adapt to this new reality. Originally-by: Stefan Hanreich Signed-off-by: Shannon Sterz --- proxmox-upgrade-checks/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-upgrade-checks/src/lib.rs b/proxmox-upgrade-checks/src/lib.rs index 4f76555a..f9b66876 100644 --- a/proxmox-upgrade-checks/src/lib.rs +++ b/proxmox-upgrade-checks/src/lib.rs @@ -202,9 +202,9 @@ impl UpgradeChecker { .iter() .find(|pkg| pkg.package.as_str() == self.meta_package_name); - if let Some(meta_pkg) = meta_pkg { + if let Some(old_version) = meta_pkg.and_then(|m| m.old_version.as_ref()) { let pkg_version = Regex::new(r"^(\d+)\.(\d+)[.-](\d+)")?; - let captures = pkg_version.captures(&meta_pkg.old_version); + let captures = pkg_version.captures(old_version); if let Some(captures) = captures { let maj = Self::extract_version_from_captures(1, &captures)?; let min = Self::extract_version_from_captures(2, &captures)?; -- 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel